| Message ID | 20200514060929.85469-2-hare@suse.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
| Series | device-mapper: use dynamic debug | expand |
On 2020/05/14 15:09, Hannes Reinecke wrote: > Switch to use dynamic debug to avoid having recompile the kernel > just to enable debugging messages. > > Signed-off-by: Hannes Reinecke <hare@suse.de> > --- > include/linux/device-mapper.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h > index af48d9da3916..4694e1bb4196 100644 > --- a/include/linux/device-mapper.h > +++ b/include/linux/device-mapper.h > @@ -557,12 +557,11 @@ void *dm_vcalloc(unsigned long nmemb, unsigned long elem_size); > #define DMINFO(fmt, ...) pr_info(DM_FMT(fmt), ##__VA_ARGS__) > #define DMINFO_LIMIT(fmt, ...) pr_info_ratelimited(DM_FMT(fmt), ##__VA_ARGS__) > > +#define DMDEBUG_LIMIT(fmt, ...) pr_debug_ratelimited(DM_FMT(fmt), ##__VA_ARGS__) Why do you move this one out of the #ifdef CONFIG_DM_DEBUG scope ? > #ifdef CONFIG_DM_DEBUG > #define DMDEBUG(fmt, ...) printk(KERN_DEBUG DM_FMT(fmt), ##__VA_ARGS__) > -#define DMDEBUG_LIMIT(fmt, ...) pr_debug_ratelimited(DM_FMT(fmt), ##__VA_ARGS__) > #else > -#define DMDEBUG(fmt, ...) no_printk(fmt, ##__VA_ARGS__) > -#define DMDEBUG_LIMIT(fmt, ...) no_printk(fmt, ##__VA_ARGS__) > +#define DMDEBUG(fmt, ...) pr_debug(DM_FMT(fmt), ##__VA_ARGS__) > #endif > > #define DMEMIT(x...) sz += ((sz >= maxlen) ? \ >
On Thu, May 14 2020 at 3:53am -0400, Damien Le Moal <Damien.LeMoal@wdc.com> wrote: > On 2020/05/14 15:09, Hannes Reinecke wrote: > > Switch to use dynamic debug to avoid having recompile the kernel > > just to enable debugging messages. > > > > Signed-off-by: Hannes Reinecke <hare@suse.de> > > --- > > include/linux/device-mapper.h | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h > > index af48d9da3916..4694e1bb4196 100644 > > --- a/include/linux/device-mapper.h > > +++ b/include/linux/device-mapper.h > > @@ -557,12 +557,11 @@ void *dm_vcalloc(unsigned long nmemb, unsigned long elem_size); > > #define DMINFO(fmt, ...) pr_info(DM_FMT(fmt), ##__VA_ARGS__) > > #define DMINFO_LIMIT(fmt, ...) pr_info_ratelimited(DM_FMT(fmt), ##__VA_ARGS__) > > > > +#define DMDEBUG_LIMIT(fmt, ...) pr_debug_ratelimited(DM_FMT(fmt), ##__VA_ARGS__) > > Why do you move this one out of the #ifdef CONFIG_DM_DEBUG scope ? I'd imagine because it already uses dynamic debugging and is useful even if CONFIG_DM_DEBUG isn't set. Makes sense to me. I'll add a note about it in the commit header though. Mike -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On Thu, May 14 2020 at 2:09am -0400, Hannes Reinecke <hare@suse.de> wrote: > Switch to use dynamic debug to avoid having recompile the kernel > just to enable debugging messages. > > Signed-off-by: Hannes Reinecke <hare@suse.de> FYI, I decided to always use pr_debug* rather than preserve using printk if CONFIG_DM_DEBUG is enabled. More consistent and less surprising for a developer (to have to reason through how to enable debugging). May cause initial surprise if debugging messages disappear despite CONFIG_DM_DEBUG being enabled... but pretty sure DM developers can cope (and/or help non-developers) as needed. Patches were staged for 5.8, I also added an additional related cleanup: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-5.8 Thanks, Mike -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h index af48d9da3916..4694e1bb4196 100644 --- a/include/linux/device-mapper.h +++ b/include/linux/device-mapper.h @@ -557,12 +557,11 @@ void *dm_vcalloc(unsigned long nmemb, unsigned long elem_size); #define DMINFO(fmt, ...) pr_info(DM_FMT(fmt), ##__VA_ARGS__) #define DMINFO_LIMIT(fmt, ...) pr_info_ratelimited(DM_FMT(fmt), ##__VA_ARGS__) +#define DMDEBUG_LIMIT(fmt, ...) pr_debug_ratelimited(DM_FMT(fmt), ##__VA_ARGS__) #ifdef CONFIG_DM_DEBUG #define DMDEBUG(fmt, ...) printk(KERN_DEBUG DM_FMT(fmt), ##__VA_ARGS__) -#define DMDEBUG_LIMIT(fmt, ...) pr_debug_ratelimited(DM_FMT(fmt), ##__VA_ARGS__) #else -#define DMDEBUG(fmt, ...) no_printk(fmt, ##__VA_ARGS__) -#define DMDEBUG_LIMIT(fmt, ...) no_printk(fmt, ##__VA_ARGS__) +#define DMDEBUG(fmt, ...) pr_debug(DM_FMT(fmt), ##__VA_ARGS__) #endif #define DMEMIT(x...) sz += ((sz >= maxlen) ? \
Switch to use dynamic debug to avoid having recompile the kernel just to enable debugging messages. Signed-off-by: Hannes Reinecke <hare@suse.de> --- include/linux/device-mapper.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)