| Message ID | 20200615033323.146312-1-houtao1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
| Series | dm zoned: assign max_io_len correctly | expand |
On 2020/06/15 12:26, Hou Tao wrote: > The unit of max_io_len is sector instead of byte (spotted through > code review), so fix it. > > Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target") > Signed-off-by: Hou Tao <houtao1@huawei.com> > --- > drivers/md/dm-zoned-target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c > index a907a9446c0b..cf915009c306 100644 > --- a/drivers/md/dm-zoned-target.c > +++ b/drivers/md/dm-zoned-target.c > @@ -890,7 +890,7 @@ static int dmz_ctr(struct dm_target *ti, unsigned int argc, char **argv) > } > > /* Set target (no write same support) */ > - ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata) << 9; > + ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata); > ti->num_flush_bios = 1; > ti->num_discard_bios = 1; > ti->num_write_zeroes_bios = 1; > Good catch ! Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c index a907a9446c0b..cf915009c306 100644 --- a/drivers/md/dm-zoned-target.c +++ b/drivers/md/dm-zoned-target.c @@ -890,7 +890,7 @@ static int dmz_ctr(struct dm_target *ti, unsigned int argc, char **argv) } /* Set target (no write same support) */ - ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata) << 9; + ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata); ti->num_flush_bios = 1; ti->num_discard_bios = 1; ti->num_write_zeroes_bios = 1;
The unit of max_io_len is sector instead of byte (spotted through code review), so fix it. Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target") Signed-off-by: Hou Tao <houtao1@huawei.com> --- drivers/md/dm-zoned-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)