diff mbox series

[v2] multipath-tools: add DellEMC/PowerStore to hardware table

Message ID 20210306025415.19329-1-xose.vazquez@gmail.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series [v2] multipath-tools: add DellEMC/PowerStore to hardware table | expand

Commit Message

Xose Vazquez Perez March 6, 2021, 2:54 a.m. UTC
Info from: https://www.delltechnologies.com/en-us/collaterals/unauth/technical-guides-support-information/products/storage-2/docu5128.pdf

Cc: Martin Wilck <mwilck@suse.com>
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: DM-DEVEL ML <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
v2: typo, change .no_path_retry from 30 to 3
---
 libmultipath/hwtable.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Martin Wilck March 11, 2021, 9:03 p.m. UTC | #1
On Sat, 2021-03-06 at 03:54 +0100, Xose Vazquez Perez wrote:
> Info from: 
> https://www.delltechnologies.com/en-us/collaterals/unauth/technical-guides-support-information/products/storage-2/docu5128.pdf
> 
> Cc: Martin Wilck <mwilck@suse.com>
> Cc: Benjamin Marzinski <bmarzins@redhat.com>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: DM-DEVEL ML <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>

Reviewed-by: Martin Wilck <mwilck@suse.com>

(although I still wonder why they use the low no_path_retry setting).

> ---
> v2: typo, change .no_path_retry from 30 to 3
> ---
>  libmultipath/hwtable.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 921aadc5..58fa7387 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -388,6 +388,17 @@ static struct hwentry default_hw[] = {
>                 .product       = "^EMC PowerMax_",
>                 .pgpolicy      = MULTIBUS,
>         },
> +       {
> +               /* PowerStore */
> +               .vendor        = "DellEMC",
> +               .product       = "PowerStore",
> +               .pgpolicy      = GROUP_BY_PRIO,
> +               .prio_name     = PRIO_ALUA,
> +               .hwhandler     = "1 alua",
> +               .pgfailback    = -FAILBACK_IMMEDIATE,
> +               .no_path_retry = 3,
> +               .fast_io_fail  = 15,
> +       },
>         /*
>          * Fujitsu
>          */



--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
diff mbox series

Patch

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 921aadc5..58fa7387 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -388,6 +388,17 @@  static struct hwentry default_hw[] = {
 		.product       = "^EMC PowerMax_",
 		.pgpolicy      = MULTIBUS,
 	},
+	{
+		/* PowerStore */
+		.vendor        = "DellEMC",
+		.product       = "PowerStore",
+		.pgpolicy      = GROUP_BY_PRIO,
+		.prio_name     = PRIO_ALUA,
+		.hwhandler     = "1 alua",
+		.pgfailback    = -FAILBACK_IMMEDIATE,
+		.no_path_retry = 3,
+		.fast_io_fail  = 15,
+	},
 	/*
 	 * Fujitsu
 	 */