| Message ID | 20210519012616.664047-1-damien.lemoal@wdc.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
| Series | dm zoned: check zone capacity | expand |
On 2021/05/19 10:26, Damien Le Moal wrote: > The dm-zoned target cannot support zoned block devices with zones that > have a capacity smaller than the zone size (e.g. NVMe zoned namespaces) > due to the current chunk zone mapping implementation as it is assumed > that zones and chunks have the same size with all blocks usable. > If a zoned drive is found to have zones with a capacity different from > the zone size, fail the target initialization. > > Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> > --- > drivers/md/dm-zoned-metadata.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c > index 039d17b28938..ee4626d08557 100644 > --- a/drivers/md/dm-zoned-metadata.c > +++ b/drivers/md/dm-zoned-metadata.c > @@ -1390,6 +1390,13 @@ static int dmz_init_zone(struct blk_zone *blkz, unsigned int num, void *data) > return -ENXIO; > } > > + /* > + * Devices that have zones with a capacity smaller than the zone size > + * (e.g. NVMe zoned namespaces) are not supported. > + */ > + if (blkz->capacity != blkz->len) > + return -ENXIO; > + > switch (blkz->type) { > case BLK_ZONE_TYPE_CONVENTIONAL: > set_bit(DMZ_RND, &zone->flags); > Hi Mike, I just realized that I forgot to add: Cc: stable@vger.kernel.org # v5.9+ to this patch. Should I resend ? Or can you add this tag when applying the patch ? Thanks !
diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c index 039d17b28938..ee4626d08557 100644 --- a/drivers/md/dm-zoned-metadata.c +++ b/drivers/md/dm-zoned-metadata.c @@ -1390,6 +1390,13 @@ static int dmz_init_zone(struct blk_zone *blkz, unsigned int num, void *data) return -ENXIO; } + /* + * Devices that have zones with a capacity smaller than the zone size + * (e.g. NVMe zoned namespaces) are not supported. + */ + if (blkz->capacity != blkz->len) + return -ENXIO; + switch (blkz->type) { case BLK_ZONE_TYPE_CONVENTIONAL: set_bit(DMZ_RND, &zone->flags);
The dm-zoned target cannot support zoned block devices with zones that have a capacity smaller than the zone size (e.g. NVMe zoned namespaces) due to the current chunk zone mapping implementation as it is assumed that zones and chunks have the same size with all blocks usable. If a zoned drive is found to have zones with a capacity different from the zone size, fail the target initialization. Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> --- drivers/md/dm-zoned-metadata.c | 7 +++++++ 1 file changed, 7 insertions(+)