| Message ID | 20211201223518.3775-2-xose.vazquez@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
| Series | [resend] multipath-tools: delete duplicate RDAC maintainer entries | expand |
@Netapp, do you approve? On Wed, 2021-12-01 at 23:35 +0100, Xose Vazquez Perez wrote: > Already at NetApp. > > Cc: Martin Wilck <mwilck@suse.com> > Cc: Benjamin Marzinski <bmarzins@redhat.com> > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> > Cc: DM-DEVEL ML <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> > --- > libmultipath/hwtable.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c > index 763982cd..1cae0ca5 100644 > --- a/libmultipath/hwtable.c > +++ b/libmultipath/hwtable.c > @@ -439,10 +439,7 @@ static struct hwentry default_hw[] = { > .no_path_retry = 10, > }, > { > - /* > - * ETERNUS AB/HB > - * Maintainer: NetApp RDAC team > <ng-eseries-upstream-maintainers@netapp.com> > - */ > + /* ETERNUS AB/HB */ > .vendor = "FUJITSU", > .product = "ETERNUS_AHB", > .bl_product = "Universal Xport", > @@ -762,11 +759,7 @@ static struct hwentry default_hw[] = { > * Lenovo > */ > { > - /* > - * DE Series > - * > - * Maintainer: NetApp RDAC team > <ng-eseries-upstream-maintainers@netapp.com> > - */ > + /* DE Series */ > .vendor = "LENOVO", > .product = "DE_Series", > .bl_product = "Universal Xport", I'd like to have this acked by Netapp before merging it. Actually, I'd prefer to have it acked by Fujitsu and Lenovo, too, but we don't have contact addresses for them, so be it. My €0.02: I'd rather not have this, because it's not obvious to everybody that these arrays are actually Netapp systems and are thus maintained not by their vendors but Netapp. Martin -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
On 12/2/21 08:56, Martin Wilck wrote: > > I'd like to have this acked by Netapp before merging it. Actually, I'd > prefer to have it acked by Fujitsu and Lenovo, too, but we don't have > contact addresses for them, so be it. > > My €0.02: I'd rather not have this, because it's not obvious to > everybody that these arrays are actually Netapp systems and are thus > maintained not by their vendors but Netapp. There are 25 RDAC arrays in hwtable, only two of them(those included in the patch) and the NetApp one have a "Maintainer" entry. And they can easily identified, .checker_name and .prio_name are RDAC. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
> From: Xose Vazquez Perez <xose.vazquez@gmail.com> > Sent: Thursday, December 2, 2021 6:42 AM > > On 12/2/21 08:56, Martin Wilck wrote: > > > > > I'd like to have this acked by Netapp before merging it. Actually, I'd > > prefer to have it acked by Fujitsu and Lenovo, too, but we don't have > > contact addresses for them, so be it. > > > > My €0.02: I'd rather not have this, because it's not obvious to > > everybody that these arrays are actually Netapp systems and are thus > > maintained not by their vendors but Netapp. > > There are 25 RDAC arrays in hwtable, only two of them(those included in > the patch) and the NetApp one have a "Maintainer" entry. > And they can easily identified, .checker_name and .prio_name are RDAC. NetApp would like those Maintainer entries to remain in the file as we have agreements with Fujitsu and Lenovo to handle it this way. Thanks, Steve -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 763982cd..1cae0ca5 100644 --- a/libmultipath/hwtable.c +++ b/libmultipath/hwtable.c @@ -439,10 +439,7 @@ static struct hwentry default_hw[] = { .no_path_retry = 10, }, { - /* - * ETERNUS AB/HB - * Maintainer: NetApp RDAC team <ng-eseries-upstream-maintainers@netapp.com> - */ + /* ETERNUS AB/HB */ .vendor = "FUJITSU", .product = "ETERNUS_AHB", .bl_product = "Universal Xport", @@ -762,11 +759,7 @@ static struct hwentry default_hw[] = { * Lenovo */ { - /* - * DE Series - * - * Maintainer: NetApp RDAC team <ng-eseries-upstream-maintainers@netapp.com> - */ + /* DE Series */ .vendor = "LENOVO", .product = "DE_Series", .bl_product = "Universal Xport",
Already at NetApp. Cc: Martin Wilck <mwilck@suse.com> Cc: Benjamin Marzinski <bmarzins@redhat.com> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com> Cc: DM-DEVEL ML <dm-devel@redhat.com> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com> --- libmultipath/hwtable.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)