diff mbox series

[4/4] multipathd.service: drop dependencies on iscsi and iscsid

Message ID 20211207200402.14157-5-mwilck@suse.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series multipathd: service unit fixes | expand

Commit Message

Martin Wilck Dec. 7, 2021, 8:04 p.m. UTC 
From: Martin Wilck <mwilck@suse.com>

We've had "Before=" dependencies on iscsi.service and iscsid.service
since this unit was first created. I'm not sure if we ever needed them.
Since c9689b6 ("multipathd: Remove dependency on
systemd-udev-settle.service"), we definitely don't. iscsi and iscsid
sort themselves after network.target, and multipathd does not, thus these
Before= dependencies are redundant.

Note: Before c9689b6, iSCSI was actually treated differently than other
transports - we forced multipathd to be started after FC device detection, but
before iSCSI device detection.

Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 multipathd/multipathd.service | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/multipathd/multipathd.service b/multipathd/multipathd.service
index 530f012..ae98034 100644
--- a/multipathd/multipathd.service
+++ b/multipathd/multipathd.service
@@ -1,6 +1,6 @@ 
 [Unit]
 Description=Device-Mapper Multipath Device Controller
-Before=iscsi.service iscsid.service lvm2-activation-early.service
+Before=lvm2-activation-early.service
 Before=local-fs-pre.target blk-availability.service shutdown.target
 Wants=systemd-udevd-kernel.socket
 After=systemd-udevd-kernel.socket