diff mbox series

[v2,09/11] multipathd: improve logging of reconfigure()

Message ID 20220318223339.4226-10-mwilck@suse.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series multipathd: fix __delayed_reconfig logic | expand

Commit Message

Martin Wilck March 18, 2022, 10:33 p.m. UTC
From: Martin Wilck <mwilck@suse.com>

Print a message when reconfigure() actually starts doing something,
and when a reconfigure() call is delayed.

Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 multipathd/main.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Benjamin Marzinski March 22, 2022, 12:35 a.m. UTC | #1
On Fri, Mar 18, 2022 at 5:33 PM <mwilck@suse.com> wrote:
>
> From: Martin Wilck <mwilck@suse.com>
>
> Print a message when reconfigure() actually starts doing something,
> and when a reconfigure() call is delayed.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>

> ---
>  multipathd/main.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 4721cd8..e841ba8 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -2840,6 +2840,7 @@ reconfigure (struct vectors *vecs, enum force_reload_types reload_type)
>         if (verbosity)
>                 libmp_verbosity = verbosity;
>         setlogmask(LOG_UPTO(libmp_verbosity + 3));
> +       condlog(2, "%s: setting up paths and maps", __func__);
>
>         /*
>          * free old map and path vectors ... they use old conf state
> @@ -3419,6 +3420,7 @@ child (__attribute__((unused)) void *param)
>                         pthread_mutex_lock(&config_lock);
>                         __delayed_reconfig = true;
>                         pthread_mutex_unlock(&config_lock);
> +                       condlog(3, "delaying reconfigure()");
>                 }
>                 lock_cleanup_pop(vecs->lock);
>                 if (!rc)
> --
> 2.35.1
>

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
diff mbox series

Patch

diff --git a/multipathd/main.c b/multipathd/main.c
index 4721cd8..e841ba8 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2840,6 +2840,7 @@  reconfigure (struct vectors *vecs, enum force_reload_types reload_type)
 	if (verbosity)
 		libmp_verbosity = verbosity;
 	setlogmask(LOG_UPTO(libmp_verbosity + 3));
+	condlog(2, "%s: setting up paths and maps", __func__);
 
 	/*
 	 * free old map and path vectors ... they use old conf state
@@ -3419,6 +3420,7 @@  child (__attribute__((unused)) void *param)
 			pthread_mutex_lock(&config_lock);
 			__delayed_reconfig = true;
 			pthread_mutex_unlock(&config_lock);
+			condlog(3, "delaying reconfigure()");
 		}
 		lock_cleanup_pop(vecs->lock);
 		if (!rc)