| Message ID | 20220318223339.4226-12-mwilck@suse.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | christophe varoqui |
| Headers | show |
| Series | multipathd: fix __delayed_reconfig logic | expand |
On Fri, Mar 18, 2022 at 5:33 PM <mwilck@suse.com> wrote: > > From: Martin Wilck <mwilck@suse.com> > > These messages are noisy in the system log without being actually helpful. I've actually found the "start up" and "shut down" messages useful a number of times, for tracking when multipathd starts up and shuts down. Since people generally run multipathd constantly, they rarely appear more than a couple of times per boot. I would prefer if they could stay. I'm fine with removing the others. -Ben > Signed-off-by: Martin Wilck <mwilck@suse.com> > --- > multipathd/main.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/multipathd/main.c b/multipathd/main.c > index 4b4fa9c..6e6635b 100644 > --- a/multipathd/main.c > +++ b/multipathd/main.c > @@ -2560,7 +2560,6 @@ checkerloop (void *ap) > rcu_register_thread(); > mlockall(MCL_CURRENT | MCL_FUTURE); > vecs = (struct vectors *)ap; > - condlog(2, "path checkers start up"); > > /* Tweak start time for initial path check */ > get_monotonic_time(&last_time); > @@ -3241,8 +3240,7 @@ child (__attribute__((unused)) void *param) > > post_config_state(DAEMON_START); > > - condlog(2, "--------start up--------"); > - condlog(2, "read " DEFAULT_CONFIGFILE); > + condlog(3, "read " DEFAULT_CONFIGFILE); > > if (verbosity) > libmp_verbosity = verbosity; > @@ -3435,7 +3433,6 @@ child (__attribute__((unused)) void *param) > > exit_code = 0; > failed: > - condlog(2, "--------shut down-------"); > /* All cleanup is done in the cleanup_child() exit handler */ > return sd_notify_exit(exit_code); > } > -- > 2.35.1 > -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
On Mon, 2022-03-21 at 19:43 -0500, Benjamin Marzinski wrote: > On Fri, Mar 18, 2022 at 5:33 PM <mwilck@suse.com> wrote: > > > > From: Martin Wilck <mwilck@suse.com> > > > > These messages are noisy in the system log without being actually > > helpful. > > I've actually found the "start up" and "shut down" messages useful a > number of times, for tracking when multipathd starts up and shuts > down. Makes sense ;-) Currently we see the following messages for multipathd startup and shutdown: Mar 11 09:30:00 bremer systemd[1]: Starting Device-Mapper Multipath Device Controller. Mar 11 09:30:01 bremer multipathd[363]: --------start up-------- Mar 11 09:30:01 bremer systemd[1]: Started Device-Mapper Multipath Device Controller. Mar 11 09:30:01 bremer multipathd[363]: read /etc/multipath.conf Mar 11 09:30:01 bremer multipathd[363]: path checkers start up ... Mar 11 09:30:52 bremer systemd[1]: Stopping Device-Mapper Multipath Device Controller... Mar 11 09:30:52 bremer multipathd[363]: exit (signal) Mar 11 09:30:52 bremer multipathd[363]: --------shut down------- Mar 11 09:30:52 bremer systemd[1]: Stopped Device-Mapper Multipath Device Controller. To my taste, this is too much. Of course, not everyone is using systemd. Without systemd and with the part of my patch you acked, we'd be down from 9 to 3 messages. IMO either the "exit" message or the "shut down" message could be hidden at -v2. I suppose we could decrease the verbosity level of handle_signals() to -v3 instead. Would you agree with that? > Since people generally run multipathd constantly, they rarely > appear more than a couple of times per boot. I would prefer if they > could stay. I'm fine with removing the others. Ok, fine with me. Do you insist on the "--------", too? It's mainly that which bothers me. If you look at the typical boot messages of contemporary Linux servers, no other daemon uses this strong emphasis for an informational message. The informational value would be higher if we printed a detailed version number including HEAD commit ID, like other daemons do. Martin -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
On Tue, Mar 22, 2022 at 4:30 AM Martin Wilck <mwilck@suse.com> wrote: > > On Mon, 2022-03-21 at 19:43 -0500, Benjamin Marzinski wrote: > > On Fri, Mar 18, 2022 at 5:33 PM <mwilck@suse.com> wrote: > > > > > > From: Martin Wilck <mwilck@suse.com> > > > > > > These messages are noisy in the system log without being actually > > > helpful. > > > > I've actually found the "start up" and "shut down" messages useful a > > number of times, for tracking when multipathd starts up and shuts > > down. > > Makes sense ;-) > > Currently we see the following messages for multipathd startup and > shutdown: > > Mar 11 09:30:00 bremer systemd[1]: Starting Device-Mapper Multipath Device Controller. > Mar 11 09:30:01 bremer multipathd[363]: --------start up-------- > Mar 11 09:30:01 bremer systemd[1]: Started Device-Mapper Multipath Device Controller. > Mar 11 09:30:01 bremer multipathd[363]: read /etc/multipath.conf > Mar 11 09:30:01 bremer multipathd[363]: path checkers start up > ... > Mar 11 09:30:52 bremer systemd[1]: Stopping Device-Mapper Multipath Device Controller... > Mar 11 09:30:52 bremer multipathd[363]: exit (signal) > Mar 11 09:30:52 bremer multipathd[363]: --------shut down------- > Mar 11 09:30:52 bremer systemd[1]: Stopped Device-Mapper Multipath Device Controller. > > To my taste, this is too much. Of course, not everyone is using > systemd. Without systemd and with the part of my patch you acked, we'd > be down from 9 to 3 messages. IMO either the "exit" message or the > "shut down" message could be hidden at -v2. I suppose we could decrease > the verbosity level of handle_signals() to -v3 instead. Would you agree > with that? Sure. > > Since people generally run multipathd constantly, they rarely > > appear more than a couple of times per boot. I would prefer if they > > could stay. I'm fine with removing the others. > > Ok, fine with me. Do you insist on the "--------", too? It's mainly > that which bothers me. If you look at the typical boot messages of > contemporary Linux servers, no other daemon uses this strong emphasis > for an informational message. The informational value would be higher > if we printed a detailed version number including HEAD commit ID, like > other daemons do. I'm fine with changing what the messages look like, I'd just like something to stay there. -Ben > Martin > -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
diff --git a/multipathd/main.c b/multipathd/main.c index 4b4fa9c..6e6635b 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -2560,7 +2560,6 @@ checkerloop (void *ap) rcu_register_thread(); mlockall(MCL_CURRENT | MCL_FUTURE); vecs = (struct vectors *)ap; - condlog(2, "path checkers start up"); /* Tweak start time for initial path check */ get_monotonic_time(&last_time); @@ -3241,8 +3240,7 @@ child (__attribute__((unused)) void *param) post_config_state(DAEMON_START); - condlog(2, "--------start up--------"); - condlog(2, "read " DEFAULT_CONFIGFILE); + condlog(3, "read " DEFAULT_CONFIGFILE); if (verbosity) libmp_verbosity = verbosity; @@ -3435,7 +3433,6 @@ child (__attribute__((unused)) void *param) exit_code = 0; failed: - condlog(2, "--------shut down-------"); /* All cleanup is done in the cleanup_child() exit handler */ return sd_notify_exit(exit_code); }