diff mbox series

[v3,11/12] multipathd: make startup / shutdown messages less noisy

Message ID 20220324211927.7152-2-mwilck@suse.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series multipathd: fix __delayed_reconfig logic | expand

Commit Message

Martin Wilck March 24, 2022, 9:19 p.m. UTC
From: Martin Wilck <mwilck@suse.com>

These messages are noisy in the system log without being actually helpful.
Print the version number on startup.

Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 multipathd/main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Benjamin Marzinski March 29, 2022, 8:34 p.m. UTC | #1
On Thu, Mar 24, 2022 at 10:19:26PM +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
> 
> These messages are noisy in the system log without being actually helpful.
> Print the version number on startup.
> 
> Signed-off-by: Martin Wilck <mwilck@suse.com>

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>

> ---
>  multipathd/main.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 9ef3197..aee0953 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -37,6 +37,7 @@
>  /*
>   * libmultipath
>   */
> +#include "version.h"
>  #include "parser.h"
>  #include "vector.h"
>  #include "config.h"
> @@ -2566,7 +2567,6 @@ checkerloop (void *ap)
>  	rcu_register_thread();
>  	mlockall(MCL_CURRENT | MCL_FUTURE);
>  	vecs = (struct vectors *)ap;
> -	condlog(2, "path checkers start up");
>  
>  	/* Tweak start time for initial path check */
>  	get_monotonic_time(&last_time);
> @@ -3247,8 +3247,8 @@ child (__attribute__((unused)) void *param)
>  
>  	post_config_state(DAEMON_START);
>  
> -	condlog(2, "--------start up--------");
> -	condlog(2, "read " DEFAULT_CONFIGFILE);
> +	condlog(2, "multipathd v%d.%d.%d: start up", MULTIPATH_VERSION(VERSION_CODE));
> +	condlog(3, "read " DEFAULT_CONFIGFILE);
>  
>  	if (verbosity)
>  		libmp_verbosity = verbosity;
> @@ -3441,7 +3441,7 @@ child (__attribute__((unused)) void *param)
>  
>  	exit_code = 0;
>  failed:
> -	condlog(2, "--------shut down-------");
> +	condlog(2, "multipathd: shut down");
>  	/* All cleanup is done in the cleanup_child() exit handler */
>  	return sd_notify_exit(exit_code);
>  }
> -- 
> 2.35.1
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
diff mbox series

Patch

diff --git a/multipathd/main.c b/multipathd/main.c
index 9ef3197..aee0953 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -37,6 +37,7 @@ 
 /*
  * libmultipath
  */
+#include "version.h"
 #include "parser.h"
 #include "vector.h"
 #include "config.h"
@@ -2566,7 +2567,6 @@  checkerloop (void *ap)
 	rcu_register_thread();
 	mlockall(MCL_CURRENT | MCL_FUTURE);
 	vecs = (struct vectors *)ap;
-	condlog(2, "path checkers start up");
 
 	/* Tweak start time for initial path check */
 	get_monotonic_time(&last_time);
@@ -3247,8 +3247,8 @@  child (__attribute__((unused)) void *param)
 
 	post_config_state(DAEMON_START);
 
-	condlog(2, "--------start up--------");
-	condlog(2, "read " DEFAULT_CONFIGFILE);
+	condlog(2, "multipathd v%d.%d.%d: start up", MULTIPATH_VERSION(VERSION_CODE));
+	condlog(3, "read " DEFAULT_CONFIGFILE);
 
 	if (verbosity)
 		libmp_verbosity = verbosity;
@@ -3441,7 +3441,7 @@  child (__attribute__((unused)) void *param)
 
 	exit_code = 0;
 failed:
-	condlog(2, "--------shut down-------");
+	condlog(2, "multipathd: shut down");
 	/* All cleanup is done in the cleanup_child() exit handler */
 	return sd_notify_exit(exit_code);
 }