diff mbox series

[v3,12/12] multipathd: decrease verbosity of handle_signal()

Message ID 20220324211927.7152-3-mwilck@suse.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series multipathd: fix __delayed_reconfig logic | expand

Commit Message

Martin Wilck March 24, 2022, 9:19 p.m. UTC
From: Martin Wilck <mwilck@suse.com>

The "reset log" message isn't very important, and the others will
be followed by more meaningful messages when multipathd actually
exits, or reconfigures itself.

Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 multipathd/main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Benjamin Marzinski March 29, 2022, 8:34 p.m. UTC | #1
On Thu, Mar 24, 2022 at 10:19:27PM +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
> 
> The "reset log" message isn't very important, and the others will
> be followed by more meaningful messages when multipathd actually
> exits, or reconfigures itself.
> 
> Signed-off-by: Martin Wilck <mwilck@suse.com>

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>

> ---
>  multipathd/main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index aee0953..1406251 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -2927,18 +2927,18 @@ void
>  handle_signals(bool nonfatal)
>  {
>  	if (exit_sig) {
> -		condlog(2, "exit (signal)");
> +		condlog(3, "exit (signal)");
>  		exit_sig = 0;
>  		exit_daemon();
>  	}
>  	if (!nonfatal)
>  		return;
>  	if (reconfig_sig) {
> -		condlog(2, "reconfigure (signal)");
> +		condlog(3, "reconfigure (signal)");
>  		schedule_reconfigure(FORCE_RELOAD_WEAK);
>  	}
>  	if (log_reset_sig) {
> -		condlog(2, "reset log (signal)");
> +		condlog(3, "reset log (signal)");
>  		if (logsink == LOGSINK_SYSLOG)
>  			log_thread_reset();
>  	}
> -- 
> 2.35.1
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
diff mbox series

Patch

diff --git a/multipathd/main.c b/multipathd/main.c
index aee0953..1406251 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2927,18 +2927,18 @@  void
 handle_signals(bool nonfatal)
 {
 	if (exit_sig) {
-		condlog(2, "exit (signal)");
+		condlog(3, "exit (signal)");
 		exit_sig = 0;
 		exit_daemon();
 	}
 	if (!nonfatal)
 		return;
 	if (reconfig_sig) {
-		condlog(2, "reconfigure (signal)");
+		condlog(3, "reconfigure (signal)");
 		schedule_reconfigure(FORCE_RELOAD_WEAK);
 	}
 	if (log_reset_sig) {
-		condlog(2, "reset log (signal)");
+		condlog(3, "reset log (signal)");
 		if (logsink == LOGSINK_SYSLOG)
 			log_thread_reset();
 	}