| Message ID | 20220727162245.209794-8-p.raghav@samsung.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
| Series | [v8,01/11] block: make bdev_nr_zones and disk_zone_no generic for npo2 zsze | expand |
On 7/28/22 01:22, Pankaj Raghav wrote: > From: Luis Chamberlain <mcgrof@kernel.org> > > dm-zoned relies on the assumption that the zone size is a > power-of-2(po2) and the zone capacity is same as the zone size. > > Ensure only po2 devices can be used as dm-zoned target until a native > non po2 support is added. > > Reviewed-by: Hannes Reinecke <hare@suse.de> > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com> > --- > drivers/md/dm-zoned-target.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c > index 95b132b52f33..16499b75c5ee 100644 > --- a/drivers/md/dm-zoned-target.c > +++ b/drivers/md/dm-zoned-target.c > @@ -792,6 +792,10 @@ static int dmz_fixup_devices(struct dm_target *ti) > return -EINVAL; > } > zone_nr_sectors = bdev_zone_sectors(bdev); > + if (!is_power_of_2(zone_nr_sectors)) { > + ti->error = "Zone size is not power of 2"; Let's clarify: ti->error = "Zone size is not a power of 2 number of sectors"; > + return -EINVAL; > + } > zoned_dev->zone_nr_sectors = zone_nr_sectors; > zoned_dev->nr_zones = bdev_nr_zones(bdev); > } > @@ -804,6 +808,10 @@ static int dmz_fixup_devices(struct dm_target *ti) > return -EINVAL; > } > zoned_dev->zone_nr_sectors = bdev_zone_sectors(bdev); > + if (!is_power_of_2(zoned_dev->zone_nr_sectors)) { > + ti->error = "Zone size is not power of 2"; Same comment. > + return -EINVAL; > + } > zoned_dev->nr_zones = bdev_nr_zones(bdev); > } >
On Wed, Jul 27, 2022 at 06:22:41PM +0200, Pankaj Raghav wrote: > --- a/drivers/md/dm-zoned-target.c > +++ b/drivers/md/dm-zoned-target.c > @@ -792,6 +792,10 @@ static int dmz_fixup_devices(struct dm_target *ti) > return -EINVAL; > } > zone_nr_sectors = bdev_zone_sectors(bdev); > + if (!is_power_of_2(zone_nr_sectors)) { > + ti->error = "Zone size is not power of 2"; This could print what's the value of zone_nr_sectors > + return -EINVAL; > + } > zoned_dev->zone_nr_sectors = zone_nr_sectors; > zoned_dev->nr_zones = bdev_nr_zones(bdev); > } > @@ -804,6 +808,10 @@ static int dmz_fixup_devices(struct dm_target *ti) > return -EINVAL; > } > zoned_dev->zone_nr_sectors = bdev_zone_sectors(bdev); > + if (!is_power_of_2(zoned_dev->zone_nr_sectors)) { > + ti->error = "Zone size is not power of 2"; Same > + return -EINVAL; > + } > zoned_dev->nr_zones = bdev_nr_zones(bdev); > } > > -- > 2.25.1 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
On 2022-07-28 14:15, David Sterba wrote: > On Wed, Jul 27, 2022 at 06:22:41PM +0200, Pankaj Raghav wrote: >> --- a/drivers/md/dm-zoned-target.c >> +++ b/drivers/md/dm-zoned-target.c >> @@ -792,6 +792,10 @@ static int dmz_fixup_devices(struct dm_target *ti) >> return -EINVAL; >> } >> zone_nr_sectors = bdev_zone_sectors(bdev); >> + if (!is_power_of_2(zone_nr_sectors)) { >> + ti->error = "Zone size is not power of 2"; > > This could print what's the value of zone_nr_sectors Ok. I will rephrase based on Damien's comment and add the zone_nr_sectors to be included. Thanks. > >> + return -EINVAL; >> + } >> zoned_dev->zone_nr_sectors = zone_nr_sectors; >> zoned_dev->nr_zones = bdev_nr_zones(bdev); >> } >> @@ -804,6 +808,10 @@ static int dmz_fixup_devices(struct dm_target *ti) >> return -EINVAL; >> } >> zoned_dev->zone_nr_sectors = bdev_zone_sectors(bdev); >> + if (!is_power_of_2(zoned_dev->zone_nr_sectors)) { >> + ti->error = "Zone size is not power of 2"; > > Same > >> + return -EINVAL; >> + } >> zoned_dev->nr_zones = bdev_nr_zones(bdev); >> } >> >> -- >> 2.25.1 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c index 95b132b52f33..16499b75c5ee 100644 --- a/drivers/md/dm-zoned-target.c +++ b/drivers/md/dm-zoned-target.c @@ -792,6 +792,10 @@ static int dmz_fixup_devices(struct dm_target *ti) return -EINVAL; } zone_nr_sectors = bdev_zone_sectors(bdev); + if (!is_power_of_2(zone_nr_sectors)) { + ti->error = "Zone size is not power of 2"; + return -EINVAL; + } zoned_dev->zone_nr_sectors = zone_nr_sectors; zoned_dev->nr_zones = bdev_nr_zones(bdev); } @@ -804,6 +808,10 @@ static int dmz_fixup_devices(struct dm_target *ti) return -EINVAL; } zoned_dev->zone_nr_sectors = bdev_zone_sectors(bdev); + if (!is_power_of_2(zoned_dev->zone_nr_sectors)) { + ti->error = "Zone size is not power of 2"; + return -EINVAL; + } zoned_dev->nr_zones = bdev_nr_zones(bdev); }