| Message ID | 20230604190604.4800-2-eatnumber1@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
| Series | Improve the dm-integrity documentation. | expand |
On Sun, Jun 04, 2023 at 12:06:01PM -0700, Russell Harmon wrote: > "where dm-integrity uses bitmap" becomes "where dm-integrity uses a > bitmap" Do you refer to one bitmap or uncountable bitmaps? I'm confused...
On Sun, Jun 4, 2023 at 8:03 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote: > > On Sun, Jun 04, 2023 at 12:06:01PM -0700, Russell Harmon wrote: > > "where dm-integrity uses bitmap" becomes "where dm-integrity uses a > > bitmap" > > Do you refer to one bitmap or uncountable bitmaps? > > I'm confused... There is only one bitmap on-disk, written to by bitmap_flush_work [1]. In-memory there's many (it's stored as a linked list of pages), but the docs seem to be implicitly referring to the on-disk representation, so this would therefore be referring to a singular map of bits, or "a bitmap." [1]: https://github.com/torvalds/linux/blob/master/drivers/md/dm-integrity.c#L2876-L2877 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
diff --git a/Documentation/admin-guide/device-mapper/dm-integrity.rst b/Documentation/admin-guide/device-mapper/dm-integrity.rst index 8db172efa272..b2a698e955a3 100644 --- a/Documentation/admin-guide/device-mapper/dm-integrity.rst +++ b/Documentation/admin-guide/device-mapper/dm-integrity.rst @@ -25,7 +25,7 @@ mode it calculates and verifies the integrity tag internally. In this mode, the dm-integrity target can be used to detect silent data corruption on the disk or in the I/O path. -There's an alternate mode of operation where dm-integrity uses bitmap +There's an alternate mode of operation where dm-integrity uses a bitmap instead of a journal. If a bit in the bitmap is 1, the corresponding region's data and integrity tags are not synchronized - if the machine crashes, the unsynchronized regions will be recalculated. The bitmap mode
"where dm-integrity uses bitmap" becomes "where dm-integrity uses a bitmap" Signed-off-by: Russell Harmon <eatnumber1@gmail.com> --- Documentation/admin-guide/device-mapper/dm-integrity.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)