| Message ID | 20240205124638.17877-7-mwilck@suse.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
| Series | multipath-tools: udev rules and service improvements | expand |
On Mon, Feb 05, 2024 at 01:46:38PM +0100, Martin Wilck wrote: > Socket activation will start multipathd on systems that don't have multipath > hardware. This is often not desired. On systems that do have multipath > hardware, OTOH, it is highly recommended to enable multipathd.service directly > rather than have it started via socket activation. Therefore don't activate > the socket by default. multipathd still supports socket activation, so users > who find it useful can disable multipathd.service and activate the socket. > > Fixes: https://github.com/opensvc/multipath-tools/issues/76 > Signed-off-by: Martin Wilck <mwilck@suse.com> > Cc: Sergio Durigan Junior <sergiodj@sergiodj.net> > Cc: Chris Hofstaedtler <zeha@debian.org> Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com> > --- > multipathd/multipathd.socket | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/multipathd/multipathd.socket b/multipathd/multipathd.socket > index c777e5e..6a62f5f 100644 > --- a/multipathd/multipathd.socket > +++ b/multipathd/multipathd.socket > @@ -10,4 +10,6 @@ Before=sockets.target > ListenStream=@/org/kernel/linux/storage/multipathd > > [Install] > -WantedBy=sockets.target > +# Socket activation for multipathd is disabled by default. > +# Activate it here if you find it useful. > +# WantedBy=sockets.target > -- > 2.43.0
diff --git a/multipathd/multipathd.socket b/multipathd/multipathd.socket index c777e5e..6a62f5f 100644 --- a/multipathd/multipathd.socket +++ b/multipathd/multipathd.socket @@ -10,4 +10,6 @@ Before=sockets.target ListenStream=@/org/kernel/linux/storage/multipathd [Install] -WantedBy=sockets.target +# Socket activation for multipathd is disabled by default. +# Activate it here if you find it useful. +# WantedBy=sockets.target
Socket activation will start multipathd on systems that don't have multipath hardware. This is often not desired. On systems that do have multipath hardware, OTOH, it is highly recommended to enable multipathd.service directly rather than have it started via socket activation. Therefore don't activate the socket by default. multipathd still supports socket activation, so users who find it useful can disable multipathd.service and activate the socket. Fixes: https://github.com/opensvc/multipath-tools/issues/76 Signed-off-by: Martin Wilck <mwilck@suse.com> Cc: Sergio Durigan Junior <sergiodj@sergiodj.net> Cc: Chris Hofstaedtler <zeha@debian.org> --- multipathd/multipathd.socket | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)