diff mbox series

dm cache metadata: remove unused struct 'thunk'

Message ID 20240523210550.309116-1-linux@treblig.org (mailing list archive)
State New, archived
Headers show
Series dm cache metadata: remove unused struct 'thunk' | expand

Commit Message

Dr. David Alan Gilbert May 23, 2024, 9:05 p.m. UTC
From: "Dr. David Alan Gilbert" <linux@treblig.org>

'thunk' has been unused since
commit f177940a8091 ("dm cache metadata: switch to using the new
cursor api for loading metadata").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/md/dm-cache-metadata.c | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Dr. David Alan Gilbert June 8, 2024, 8:49 p.m. UTC | #1
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'thunk' has been unused since
> commit f177940a8091 ("dm cache metadata: switch to using the new
> cursor api for loading metadata").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping

> ---
>  drivers/md/dm-cache-metadata.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
> index 96751cd3d181..0ad9dc1824fa 100644
> --- a/drivers/md/dm-cache-metadata.c
> +++ b/drivers/md/dm-cache-metadata.c
> @@ -1282,15 +1282,6 @@ int dm_cache_insert_mapping(struct dm_cache_metadata *cmd,
>  	return r;
>  }
>  
> -struct thunk {
> -	load_mapping_fn fn;
> -	void *context;
> -
> -	struct dm_cache_metadata *cmd;
> -	bool respect_dirty_flags;
> -	bool hints_valid;
> -};
> -
>  static bool policy_unchanged(struct dm_cache_metadata *cmd,
>  			     struct dm_cache_policy *policy)
>  {
> -- 
> 2.45.1
>
Matthew Sakai June 25, 2024, 6:37 p.m. UTC | #2
On 5/23/24 17:05, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'thunk' has been unused since
> commit f177940a8091 ("dm cache metadata: switch to using the new
> cursor api for loading metadata").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Matthew Sakai <msakai@redhat.com>

> ---
>   drivers/md/dm-cache-metadata.c | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
> index 96751cd3d181..0ad9dc1824fa 100644
> --- a/drivers/md/dm-cache-metadata.c
> +++ b/drivers/md/dm-cache-metadata.c
> @@ -1282,15 +1282,6 @@ int dm_cache_insert_mapping(struct dm_cache_metadata *cmd,
>   	return r;
>   }
>   
> -struct thunk {
> -	load_mapping_fn fn;
> -	void *context;
> -
> -	struct dm_cache_metadata *cmd;
> -	bool respect_dirty_flags;
> -	bool hints_valid;
> -};
> -
>   static bool policy_unchanged(struct dm_cache_metadata *cmd,
>   			     struct dm_cache_policy *policy)
>   {
diff mbox series

Patch

diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
index 96751cd3d181..0ad9dc1824fa 100644
--- a/drivers/md/dm-cache-metadata.c
+++ b/drivers/md/dm-cache-metadata.c
@@ -1282,15 +1282,6 @@  int dm_cache_insert_mapping(struct dm_cache_metadata *cmd,
 	return r;
 }
 
-struct thunk {
-	load_mapping_fn fn;
-	void *context;
-
-	struct dm_cache_metadata *cmd;
-	bool respect_dirty_flags;
-	bool hints_valid;
-};
-
 static bool policy_unchanged(struct dm_cache_metadata *cmd,
 			     struct dm_cache_policy *policy)
 {