diff mbox series

[2/2] dm: Remove max_secure_erase_granularity

Message ID 20240703221336.503507-3-dlemoal@kernel.org (mailing list archive)
State New
Headers show
Series Remove unused dm_target fields | expand

Commit Message

Damien Le Moal July 3, 2024, 10:13 p.m. UTC 
The max_secure_erase_granularity boolean of struct dm_target is used in
__process_abnormal_io() but never set by any target. Remove this field
and the dead code using it.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
---
 drivers/md/dm.c               | 2 --
 include/linux/device-mapper.h | 6 ------
 2 files changed, 8 deletions(-)

Comments

Christoph Hellwig July 4, 2024, 6:17 a.m. UTC | #1 
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index a63efa2a46ae..2abf2b6865ea 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -1658,8 +1658,6 @@  static blk_status_t __process_abnormal_io(struct clone_info *ci,
 	case REQ_OP_SECURE_ERASE:
 		num_bios = ti->num_secure_erase_bios;
 		max_sectors = limits->max_secure_erase_sectors;
-		if (ti->max_secure_erase_granularity)
-			max_granularity = max_sectors;
 		break;
 	case REQ_OP_WRITE_ZEROES:
 		num_bios = ti->num_write_zeroes_bios;
diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
index 5b7e96653ec6..4ba2e73993bd 100644
--- a/include/linux/device-mapper.h
+++ b/include/linux/device-mapper.h
@@ -363,12 +363,6 @@  struct dm_target {
 	 */
 	bool max_discard_granularity:1;
 
-	/*
-	 * Set if this target requires that secure_erases be split on
-	 * 'max_secure_erase_sectors' boundaries.
-	 */
-	bool max_secure_erase_granularity:1;
-
 	/*
 	 * Set if we need to limit the number of in-flight bios when swapping.
 	 */