diff mbox series

[04/41] libmpathutil.version: remove strlcpy and strlcat, and LIBMULTIPATH section

Message ID 20240808152620.93965-5-mwilck@suse.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series multipath-tools: comply with C library reserved names | expand

Commit Message

Martin Wilck Aug. 8, 2024, 3:25 p.m. UTC
With the removal of strlcpy from the "symbols referenced by multipath
and multipathd" section, this part of the ABI (which is actually the
part of LIBMULTIPATH_16.0.0 which was moved to libmpathutil and exported
to multipath and/or multipathd) has now changed for the first time since
the split between libmpathutil and libmultipath.

It makes no sense to further track whether or not any symbols exported
by libmpathutil are used by multipath or multipathd. It turns out that
both executables were already using some symbols from the sections that
were supposedly used by libmultipath only.

Therefore, move all symbols to the new LIBMPATHUTIL_4.0 ABI.

Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 libmpathutil/libmpathutil.version | 104 +++++++++++++-----------------
 1 file changed, 46 insertions(+), 58 deletions(-)
diff mbox series

Patch

diff --git a/libmpathutil/libmpathutil.version b/libmpathutil/libmpathutil.version
index cb05231..8393b91 100644
--- a/libmpathutil/libmpathutil.version
+++ b/libmpathutil/libmpathutil.version
@@ -43,98 +43,86 @@  LIBMPATHCOMMON_1.0.0 {
 	put_multipath_config;
 };
 
-/* symbols referenced by multipath and multipathd */
-LIBMULTIPATH_16.0.0 {
+LIBMPATHUTIL_4.0 {
 global:
+	alloc_bitfield;
 	alloc_strvec;
+	__append_strbuf_str;
 	append_strbuf_str;
+	append_strbuf_quoted;
+	basenamecpy;
 	cleanup_charp;
+	cleanup_fclose;
+	cleanup_fd_ptr;
+	cleanup_free_ptr;
 	cleanup_mutex;
 	cleanup_ucharp;
+	cleanup_udev_device;
+	cleanup_vector;
+	cleanup_vector_free;
 	convert_dev;
 	dlog;
+	filepresent;
 	fill_strbuf;
+	find_keyword;
 	find_slot;
+	free_keywords;
 	free_scandir_result;
 	free_strvec;
+	get_linux_version_code;
 	get_monotonic_time;
+	__get_strbuf_buf;
 	get_next_string;
 	get_strbuf_len;
 	get_strbuf_str;
-	is_quote;
-	libmp_verbosity;
-	log_thread_reset;
-	log_thread_start;
-	log_thread_stop;
-	logsink;
-	normalize_timespec;
-	print_strbuf;
-	pthread_cond_init_mono;
-	recv_packet;
-	reset_strbuf;
-	send_packet;
-	set_max_fds;
-	setup_thread_attr;
-	strchop;
-	strlcpy;
-	timespeccmp;
-	timespecsub;
-	truncate_strbuf;
-	ux_socket_listen;
-	vector_alloc;
-	vector_alloc_slot;
-	vector_del_slot;
-	vector_free;
-	vector_reset;
-	vector_set_slot;
-
-local:
-	*;
-};
-
-/* symbols referenced internally by libmultipath */
-LIBMPATHUTIL_2.0 {
-	alloc_bitfield;
-	__append_strbuf_str;
-	append_strbuf_quoted;
-	basenamecpy;
-	cleanup_fd_ptr;
-	cleanup_free_ptr;
-	cleanup_vector_free;
-	cleanup_fclose;
-	filepresent;
-	find_keyword;
-	free_keywords;
-	get_linux_version_code;
-	__get_strbuf_buf;
 	get_word;
 	_install_keyword;
 	install_sublevel;
 	install_sublevel_end;
+	is_quote;
 	keyword_alloc;
 	_log_bitfield_overflow;
+	libmp_basename;
+	libmp_strlcat;
+	libmp_strlcpy;
+	libmp_verbosity;
 	log_safe;
+	log_thread_reset;
+	log_thread_start;
+	log_thread_stop;
+	logsink;
 	msort;
+	normalize_timespec;
 	parse_devt;
+	print_strbuf;
 	process_file;
+	pthread_cond_init_mono;
+	recv_packet;
+	reset_strbuf;
 	safe_write;
+	send_packet;
+	set_max_fds;
 	set_value;
+	setup_thread_attr;
+	strchop;
 	should_exit;
 	snprint_keyword;
 	steal_strbuf_str;
-	strlcat;
+	timespeccmp;
+	timespecsub;
+	truncate_strbuf;
 	validate_config_strvec;
+	ux_socket_listen;
+	vector_alloc;
+	vector_alloc_slot;
+	vector_del_slot;
 	vector_find_or_add_slot;
+	vector_free;
 	vector_insert_slot;
 	vector_move_up;
+	vector_reset;
+	vector_set_slot;
 	vector_sort;
-};
-
-LIBMPATHUTIL_2.1 {
-	libmp_basename;
-};
-
-LIBMPATHUTIL_2.2 {
-	cleanup_udev_device;
-	cleanup_vector;
+local:
+	*;
 };