diff mbox series

multipath-tools: hwtable housekeeping

Message ID 20240924235523.56471-1-xose.vazquez@gmail.com (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series multipath-tools: hwtable housekeeping | expand

Commit Message

Xose Vazquez Perez Sept. 24, 2024, 11:55 p.m. UTC
Update some descriptions. And limit the Dorado regex,
because "Dorado "is used as a generic brand by Huawei.

=====================    
HUASY   Dorado2100
HUAWEI  Dorado2100
HUAWEI  Dorado2100 G2
HUASY   Dorado5100
HUAWEI  Dorado5100
=====================    

Cc: Martin Wilck <mwilck@suse.com>
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: DM-DEVEL ML <dm-devel@lists.linux.dev>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Benjamin Marzinski Sept. 26, 2024, 8:56 p.m. UTC | #1
On Wed, Sep 25, 2024 at 01:55:22AM +0200, Xose Vazquez Perez wrote:
> Update some descriptions. And limit the Dorado regex,
> because "Dorado "is used as a generic brand by Huawei.
> 
> =====================    
> HUASY   Dorado2100
> HUAWEI  Dorado2100
> HUAWEI  Dorado2100 G2
> HUASY   Dorado5100
> HUAWEI  Dorado5100
> =====================    
> 
> Cc: Martin Wilck <mwilck@suse.com>
> Cc: Benjamin Marzinski <bmarzins@redhat.com>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: DM-DEVEL ML <dm-devel@lists.linux.dev>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>

> ---
>  libmultipath/hwtable.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index c539a9b5..01d50303 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -819,7 +819,7 @@ static struct hwentry default_hw[] = {
>  	 */
>  	{
>  		/*
> -		 * ONTAP FAS/AFF Series
> +		 * ONTAP FAS/AFF/ASA Series
>  		 *
>  		 * Maintainer: Martin George <marting@netapp.com>
>  		 */
> @@ -1099,7 +1099,7 @@ static struct hwentry default_hw[] = {
>  	 * Pure Storage
>  	 */
>  	{
> -		/* FlashArray */
> +		/* FlashArray family */
>  		.vendor        = "PURE",
>  		.product       = "FlashArray",
>  		.pgpolicy      = GROUP_BY_PRIO,
> @@ -1120,15 +1120,15 @@ static struct hwentry default_hw[] = {
>  	 * Huawei
>  	 */
>  	{
> -		/* All, except OceanStor V3-V6 */
> +		/* Older than OceanStor V3 */
>  		.vendor        = "^(HUAWEI|HUASY|HS)",
> -		.product       = "^(Dorado|HVS8|S[23568]|V1[568]|VIS6000)",
> +		.product       = "^(Dorado[25]|HVS8|S[23568]|V1[568]|VIS6000)",
>  		.pgpolicy      = GROUP_BY_PRIO,
>  		.pgfailback    = -FAILBACK_IMMEDIATE,
>  		.no_path_retry = 15,
>  	},
>  	{
> -		/* OceanStor V3-V6 */
> +		/* OceanStor V3 or better */
>  		.vendor        = "^(HUAWEI|AnyStor|Marstor|NETPOSA|SanM|SUGON|UDsafe)",
>  		.product       = "XSG1",
>  		.pgpolicy      = GROUP_BY_PRIO,
> -- 
> 2.46.1
diff mbox series

Patch

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index c539a9b5..01d50303 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -819,7 +819,7 @@  static struct hwentry default_hw[] = {
 	 */
 	{
 		/*
-		 * ONTAP FAS/AFF Series
+		 * ONTAP FAS/AFF/ASA Series
 		 *
 		 * Maintainer: Martin George <marting@netapp.com>
 		 */
@@ -1099,7 +1099,7 @@  static struct hwentry default_hw[] = {
 	 * Pure Storage
 	 */
 	{
-		/* FlashArray */
+		/* FlashArray family */
 		.vendor        = "PURE",
 		.product       = "FlashArray",
 		.pgpolicy      = GROUP_BY_PRIO,
@@ -1120,15 +1120,15 @@  static struct hwentry default_hw[] = {
 	 * Huawei
 	 */
 	{
-		/* All, except OceanStor V3-V6 */
+		/* Older than OceanStor V3 */
 		.vendor        = "^(HUAWEI|HUASY|HS)",
-		.product       = "^(Dorado|HVS8|S[23568]|V1[568]|VIS6000)",
+		.product       = "^(Dorado[25]|HVS8|S[23568]|V1[568]|VIS6000)",
 		.pgpolicy      = GROUP_BY_PRIO,
 		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.no_path_retry = 15,
 	},
 	{
-		/* OceanStor V3-V6 */
+		/* OceanStor V3 or better */
 		.vendor        = "^(HUAWEI|AnyStor|Marstor|NETPOSA|SanM|SUGON|UDsafe)",
 		.product       = "XSG1",
 		.pgpolicy      = GROUP_BY_PRIO,