diff mbox series

[3/3] multipathd: don't update paths in INIT_MISSING_UDEV

Message ID 20250324205504.2523493-4-bmarzins@redhat.com (mailing list archive)
State New
Headers show
Series fix issue of multipathd not tracking device | expand

Commit Message

Benjamin Marzinski March 24, 2025, 8:55 p.m. UTC
There is nothing for update_uninitialized_path() to do for paths in the
INIT_MISSING_UDEV state. In fact, there shouldn't be any paths in this
state when update_uninitialized_path() is called, since they will have
switched to a different state in check_uninitialized_path().

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
 multipathd/main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Martin Wilck March 25, 2025, 10:40 p.m. UTC | #1
On Mon, 2025-03-24 at 16:55 -0400, Benjamin Marzinski wrote:
> There is nothing for update_uninitialized_path() to do for paths in
> the
> INIT_MISSING_UDEV state. In fact, there shouldn't be any paths in
> this
> state when update_uninitialized_path() is called, since they will
> have
> switched to a different state in check_uninitialized_path().
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>

Reviewed-by: Martin Wilck  <mwilck@suse.com>


> ---
>  multipathd/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index ecad5a4f..9c44e6e6 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -2889,7 +2889,6 @@ update_uninitialized_path(struct vectors *
> vecs, struct path * pp)
>  	struct config *conf;
>  
>  	if (pp->initialized != INIT_NEW && pp->initialized !=
> INIT_FAILED &&
> -	    pp->initialized != INIT_MISSING_UDEV &&
>  	    pp->initialized != INIT_OFFLINE)
>  		return CHECK_PATH_SKIPPED;
>
diff mbox series

Patch

diff --git a/multipathd/main.c b/multipathd/main.c
index ecad5a4f..9c44e6e6 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2889,7 +2889,6 @@  update_uninitialized_path(struct vectors * vecs, struct path * pp)
 	struct config *conf;
 
 	if (pp->initialized != INIT_NEW && pp->initialized != INIT_FAILED &&
-	    pp->initialized != INIT_MISSING_UDEV &&
 	    pp->initialized != INIT_OFFLINE)
 		return CHECK_PATH_SKIPPED;