From patchwork Wed Sep 28 15:47:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9355833 X-Patchwork-Delegate: snitzer@redhat.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0A4A2600C8 for ; Thu, 29 Sep 2016 07:57:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F0A9129894 for ; Thu, 29 Sep 2016 07:57:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E59A02989A; Thu, 29 Sep 2016 07:57:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com [209.132.183.37]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8D46329894 for ; Thu, 29 Sep 2016 07:57:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8T7t4NL040984; Thu, 29 Sep 2016 03:55:04 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u8SFlAjF024786 for ; Wed, 28 Sep 2016 11:47:10 -0400 Received: from mx1.redhat.com (ext-mx06.extmail.prod.ext.phx2.redhat.com [10.5.110.30]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8SFlA4c031148 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 28 Sep 2016 11:47:10 -0400 Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1C7FB3F202; Wed, 28 Sep 2016 15:47:09 +0000 (UTC) Received: from [192.168.1.2] ([78.48.47.99]) by smtp.web.de (mrweb004) with ESMTPSA (Nemesis) id 0M0O2H-1awtnj1XHp-00uXpu; Wed, 28 Sep 2016 17:47:06 +0200 To: dm-devel@redhat.com, linux-raid@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Shaohua Li References: <566ABCD9.1060404@users.sourceforge.net> <7c232017-e291-fd2d-5516-26e5150d90df@users.sourceforge.net> From: SF Markus Elfring Message-ID: <3ce9ee21-2c4e-2b3b-1193-93dbec6fc8d1@users.sourceforge.net> Date: Wed, 28 Sep 2016 17:47:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <7c232017-e291-fd2d-5516-26e5150d90df@users.sourceforge.net> X-Provags-ID: V03:K0:6Q43yQexVHvltDUa/o1J5lLD1HK6B46k6PZIFMm7VOk2NF1jbIS AqAZkMe2ynA3u0BmyXfWz0+M49xsDXHAf9WfLKZjc6/CxVeipc/MDSOxnkFtvrkno4voBw4 vYG2JbPHbuYLIP/fXLNJ30+6trAu9+nwAcgg03XDZq2gh775aFSRifstpTqHowOAAtPuugE wslX1saiTwS7ApYfWa9KQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:FYjjH+LD7Xs=:NhAlJJFqAJhwTYVpj9rShl pmx39uvlm+6obNijZd4nWUPAHWIC0WaTw9gbTu+uXJvch5zSWCQJ2KQItk20jt8OLguYTcx8s dMuktpkeQyi63SDjelcCRyC7nOsiw21uF9FKSJb35Z5FpDopsis9BSx5GDpWdUDS2aqfG8GU2 sX4Ui7PV2bvS9Pj/9TcyUCnUjxKK2gP1l8kiE46F70W/yUBCjTus7uP6jvoGPDh7V0zNwwsiV tvfDCXQ5OBeXYnsX0Zng6CGizEJFlpguFHqREq5kZ6Lxgr3ds0cFVLiQVFdSFK1f7rdGU/6VO jIC44qEzNhGURU0hac58pd+DHYxey4TkVitMwdkSmFhOZsM0Hcf1y2NXUvIcYBcgI3aF6ZHfT pnjlR09VspvELCCsprzdWxLYjV+70jblaD0vcE6j0WvHYpaOq4hM34sxHTVBElcuRva4Kq8Qd TB2Xcxq/HhEg3POoJgWxA+xcY30gmZx+pqty11TS+FdgaG6dZwgPHOQMJJ3zg1WYo/dvdCrvI JKPb7kLAJkggEOeXXx8j+I2GXWxhmIwkxhCePvIzAlysJ20N5JvIRTHMx8FpF4H9Lzn3y0QDM 1GUMXKSVCp47+lNc+kBvdtXoR+BNCpeIVgPDnKeMf+/8d6M4nZjeXaf+AUniMrjTRjfYxAbx0 pLbwtvYp0cUggkkYf+uNjkNrPfBAEHsK3WnYVwsc7Tm2R1GIOb+C01Ya8LI/rpFwh1DDUMl/t 5mEeeF6WlIxxrXcj9vm2TXCN2vGcATCzndQaGGbqnUMc6Ee9hHJVWEF5JjpayHNc6bK/IdNbV PobT1Qm X-Greylist: Sender IP whitelisted by DNSRBL, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 28 Sep 2016 15:47:09 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 28 Sep 2016 15:47:09 +0000 (UTC) for IP:'212.227.15.4' DOMAIN:'mout.web.de' HELO:'mout.web.de' FROM:'elfring@users.sourceforge.net' RCPT:'' X-RedHat-Spam-Score: 0.079 (BAYES_50, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 212.227.15.4 mout.web.de 212.227.15.4 mout.web.de X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Scanned-By: MIMEDefang 2.78 on 10.5.110.30 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Thu, 29 Sep 2016 03:54:16 -0400 Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: [dm-devel] [PATCH 10/10] md/dm-crypt: Delete unnecessary variable initialisations in crypt_iv_essiv_ctr() X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Wed, 28 Sep 2016 16:44:32 +0200 Three local variables will be set to an appropriate pointer a bit later. Thus omit the explicit initialisation which became unnecessary with a previous update step. Signed-off-by: Markus Elfring --- drivers/md/dm-crypt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index 53a9155..d27716e 100644 --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -361,9 +361,9 @@ static void crypt_iv_essiv_dtr(struct crypt_config *cc) static int crypt_iv_essiv_ctr(struct crypt_config *cc, struct dm_target *ti, const char *opts) { - struct crypto_cipher *essiv_tfm = NULL; - struct crypto_ahash *hash_tfm = NULL; - u8 *salt = NULL; + struct crypto_cipher *essiv_tfm; + struct crypto_ahash *hash_tfm; + u8 *salt; int err; if (!opts) {