diff mbox

multipath: Wrong sysfs attribute used for iSCSI settings.

Message ID 47bff49ac3c742fc86a11b013a76e985@hioexcmbx01-prd.hq.netapp.com (mailing list archive)
State Accepted, archived
Delegated to: christophe varoqui
Headers show

Commit Message

Merla, ShivaKrishna June 20, 2014, 10:33 p.m. UTC
Wrong sysfs parameter used to configure iSCSI settings.

/sys/class/iscsi_session/session<n>/tgtname
It's always
/sys/class/iscsi_session/session<n>/targetname

This is the reason recovery_tmo was not getting set to 
fast_io_fail_tmo value for iscsi sessions.

Signed-off-by: Shiva Krishna Merla<shivakrishna.merla@netapp.com>
---
 libmultipath/discovery.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

--

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Comments

Christophe Varoqui July 24, 2014, 8:33 a.m. UTC | #1
Applied,
Thanks.


On Sat, Jun 21, 2014 at 12:33 AM, Merla, ShivaKrishna <
ShivaKrishna.Merla@netapp.com> wrote:

> Wrong sysfs parameter used to configure iSCSI settings.
>
> /sys/class/iscsi_session/session<n>/tgtname
> It's always
> /sys/class/iscsi_session/session<n>/targetname
>
> This is the reason recovery_tmo was not getting set to
> fast_io_fail_tmo value for iscsi sessions.
>
> Signed-off-by: Shiva Krishna Merla<shivakrishna.merla@netapp.com>
> ---
>  libmultipath/discovery.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
> index 786e1de..7bb0a33 100644
> --- a/libmultipath/discovery.c
> +++ b/libmultipath/discovery.c
> @@ -289,7 +289,7 @@ sysfs_get_tgt_nodename (struct path *pp, char * node)
>                 if (tgtdev) {
>                         const char *value;
>
> -                       value = udev_device_get_sysattr_value(tgtdev,
> "tgtname");
> +                       value = udev_device_get_sysattr_value(tgtdev,
> "targetname");
>                         if (value) {
>                                 pp->sg_id.proto_id = SCSI_PROTOCOL_ISCSI;
>                                 pp->sg_id.transport_id = tgtid;
> --
>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index 786e1de..7bb0a33 100644
--- a/libmultipath/discovery.c
+++ b/libmultipath/discovery.c
@@ -289,7 +289,7 @@  sysfs_get_tgt_nodename (struct path *pp, char * node)
 		if (tgtdev) {
 			const char *value;
 
-			value = udev_device_get_sysattr_value(tgtdev, "tgtname");
+			value = udev_device_get_sysattr_value(tgtdev, "targetname");
 			if (value) {
 				pp->sg_id.proto_id = SCSI_PROTOCOL_ISCSI;
 				pp->sg_id.transport_id = tgtid;