diff mbox

Re: [PATCH 10/20] io-conroller: Prepare elevator layer for single queue schedulers

Message ID 4A28E293.90402@cn.fujitsu.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gui Jianfeng June 5, 2009, 9:17 a.m. UTC
Vivek Goyal wrote:
> +				e->ops->elevator_free_sched_queue_fn(e,
> +							sched_q);
> +				sched_q = NULL;
> +				goto queue_fail;
> +			}
> +		}
> +
> +		elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE, 4, 1);

It's better to use IOPRIO_NORM here.

Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
 block/elevator-fq.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Vivek Goyal June 5, 2009, 1:22 p.m. UTC | #1
On Fri, Jun 05, 2009 at 05:17:07PM +0800, Gui Jianfeng wrote:
> Vivek Goyal wrote:
> > +				e->ops->elevator_free_sched_queue_fn(e,
> > +							sched_q);
> > +				sched_q = NULL;
> > +				goto queue_fail;
> > +			}
> > +		}
> > +
> > +		elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE, 4, 1);
> 
> It's better to use IOPRIO_NORM here.
> 

Sure. Queued up for next posting.

Thanks
Vivek

> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
>  block/elevator-fq.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/block/elevator-fq.c b/block/elevator-fq.c
> index f1179aa..3c5f9da 100644
> --- a/block/elevator-fq.c
> +++ b/block/elevator-fq.c
> @@ -2403,7 +2403,8 @@ alloc_ioq:
>  			}
>  		}
>  
> -		elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE, 4, 1);
> +		elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE,
> +			     IOPRIO_NORM, 1);
>  		io_group_set_ioq(iog, ioq);
>  		elv_mark_ioq_sync(ioq);
>  		elv_get_iog(iog);
> -- 
> 1.5.4.rc3

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

diff --git a/block/elevator-fq.c b/block/elevator-fq.c
index f1179aa..3c5f9da 100644
--- a/block/elevator-fq.c
+++ b/block/elevator-fq.c
@@ -2403,7 +2403,8 @@  alloc_ioq:
 			}
 		}
 
-		elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE, 4, 1);
+		elv_init_ioq(e, ioq, iog, sched_q, IOPRIO_CLASS_BE,
+			     IOPRIO_NORM, 1);
 		io_group_set_ioq(iog, ioq);
 		elv_mark_ioq_sync(ioq);
 		elv_get_iog(iog);