diff mbox

Re: [PATCH 02/20] io-controller: Common flat fair queuing code in elevaotor layer

Message ID 4A2CC15F.2010708@cn.fujitsu.com (mailing list archive)
State New, archived
Headers show

Commit Message

Gui Jianfeng June 8, 2009, 7:44 a.m. UTC 
Vivek Goyal wrote:
...
> +
> +static inline pid_t elv_ioq_pid(struct io_queue *ioq)
> +{
> +	return ioq->pid;
> +}
> +
> +static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq)
> +{
> +	return ioq->ttime_mean;
> +}
> +
> +static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq)
> +{
> +	return ioq_sample_valid(ioq->ttime_samples);
> +}
> +

These three functions are dead now, just remove them.

Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
 block/elevator-fq.h |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)

Comments

Vivek Goyal June 8, 2009, 1:56 p.m. UTC | #1 
On Mon, Jun 08, 2009 at 03:44:31PM +0800, Gui Jianfeng wrote:
> Vivek Goyal wrote:
> ...
> > +
> > +static inline pid_t elv_ioq_pid(struct io_queue *ioq)
> > +{
> > +	return ioq->pid;
> > +}
> > +
> > +static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq)
> > +{
> > +	return ioq->ttime_mean;
> > +}
> > +
> > +static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq)
> > +{
> > +	return ioq_sample_valid(ioq->ttime_samples);
> > +}
> > +
> 
> These three functions are dead now, just remove them.
> 

Thanks Gui. queued up for next posting.

Thanks
Vivek

> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
>  block/elevator-fq.h |   15 ---------------
>  1 files changed, 0 insertions(+), 15 deletions(-)
> 
> diff --git a/block/elevator-fq.h b/block/elevator-fq.h
> index 24a3af9..b2bb11a 100644
> --- a/block/elevator-fq.h
> +++ b/block/elevator-fq.h
> @@ -452,21 +452,6 @@ static inline int elv_ioq_nr_queued(struct io_queue *ioq)
>  	return ioq->nr_queued;
>  }
>  
> -static inline pid_t elv_ioq_pid(struct io_queue *ioq)
> -{
> -	return ioq->pid;
> -}
> -
> -static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq)
> -{
> -	return ioq->ttime_mean;
> -}
> -
> -static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq)
> -{
> -	return ioq_sample_valid(ioq->ttime_samples);
> -}
> -
>  static inline void elv_get_ioq(struct io_queue *ioq)
>  {
>  	atomic_inc(&ioq->ref);
> -- 
> 1.5.4.rc3

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

diff --git a/block/elevator-fq.h b/block/elevator-fq.h
index 24a3af9..b2bb11a 100644
--- a/block/elevator-fq.h
+++ b/block/elevator-fq.h
@@ -452,21 +452,6 @@  static inline int elv_ioq_nr_queued(struct io_queue *ioq)
 	return ioq->nr_queued;
 }
 
-static inline pid_t elv_ioq_pid(struct io_queue *ioq)
-{
-	return ioq->pid;
-}
-
-static inline unsigned long elv_ioq_ttime_mean(struct io_queue *ioq)
-{
-	return ioq->ttime_mean;
-}
-
-static inline unsigned long elv_ioq_sample_valid(struct io_queue *ioq)
-{
-	return ioq_sample_valid(ioq->ttime_samples);
-}
-
 static inline void elv_get_ioq(struct io_queue *ioq)
 {
 	atomic_inc(&ioq->ref);