From patchwork Thu Jun 11 06:12:44 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gui Jianfeng X-Patchwork-Id: 29473 Received: from hormel.redhat.com (hormel1.redhat.com [209.132.177.33]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n5B6EsSq016561 for ; Thu, 11 Jun 2009 06:14:54 GMT Received: from listman.util.phx.redhat.com (listman.util.phx.redhat.com [10.8.4.110]) by hormel.redhat.com (Postfix) with ESMTP id AA4F261906B; Thu, 11 Jun 2009 02:14:53 -0400 (EDT) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by listman.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n5B6EoJr007287 for ; Thu, 11 Jun 2009 02:14:50 -0400 Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5B6Ek3j019947; Thu, 11 Jun 2009 02:14:46 -0400 Received: from song.cn.fujitsu.com (cn.fujitsu.com [222.73.24.84] (may be forged)) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id n5B6EXLF022034; Thu, 11 Jun 2009 02:14:33 -0400 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id 05FC6170144; Thu, 11 Jun 2009 14:38:00 +0800 (CST) Received: from fnst.cn.fujitsu.com (localhost.localdomain [127.0.0.1]) by tang.cn.fujitsu.com (8.13.1/8.13.1) with ESMTP id n5B6SN6U012597; Thu, 11 Jun 2009 14:28:23 +0800 Received: from [127.0.0.1] (unknown [10.167.141.226]) by fnst.cn.fujitsu.com (Postfix) with ESMTPA id C442DD4016; Thu, 11 Jun 2009 14:14:35 +0800 (CST) Message-ID: <4A30A05C.4060703@cn.fujitsu.com> Date: Thu, 11 Jun 2009 14:12:44 +0800 From: Gui Jianfeng User-Agent: Thunderbird 2.0.0.5 (Windows/20070716) MIME-Version: 1.0 To: Vivek Goyal References: <1244513342-11758-1-git-send-email-vgoyal@redhat.com> <1244513342-11758-5-git-send-email-vgoyal@redhat.com> In-Reply-To: <1244513342-11758-5-git-send-email-vgoyal@redhat.com> X-RedHat-Spam-Score: -0.725 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-Scanned-By: MIMEDefang 2.63 on 172.16.48.32 X-loop: dm-devel@redhat.com Cc: dhaval@linux.vnet.ibm.com, snitzer@redhat.com, peterz@infradead.org, dm-devel@redhat.com, dpshah@google.com, jens.axboe@oracle.com, agk@redhat.com, balbir@linux.vnet.ibm.com, paolo.valente@unimore.it, fernando@oss.ntt.co.jp, mikew@google.com, jmoyer@redhat.com, nauman@google.com, m-ikeda@ds.jp.nec.com, lizf@cn.fujitsu.com, fchecconi@gmail.com, akpm@linux-foundation.org, jbaron@redhat.com, linux-kernel@vger.kernel.org, s-uchida@ap.jp.nec.com, righi.andrea@gmail.com, containers@lists.linux-foundation.org Subject: [dm-devel] Re: [PATCH 04/19] io-controller: Modify cfq to make use of flat elevator fair queuing X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.5 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com Vivek Goyal wrote: > This patch changes cfq to use fair queuing code from elevator layer. > last_end_request in cic is of no use anymore. Get rid of it. Signed-off-by: Gui Jianfeng --- block/cfq-iosched.c | 4 ---- include/linux/iocontext.h | 1 - 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 5871568..705e7ba 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c @@ -1170,7 +1170,6 @@ cfq_alloc_io_context(struct cfq_data *cfqd, gfp_t gfp_mask) cic = kmem_cache_alloc_node(cfq_ioc_pool, gfp_mask | __GFP_ZERO, q->node); if (cic) { - cic->last_end_request = jiffies; INIT_LIST_HEAD(&cic->queue_list); INIT_HLIST_NODE(&cic->cic_list); cic->dtor = cfq_free_io_context; @@ -1794,9 +1793,6 @@ static void cfq_completed_request(struct request_queue *q, struct request *rq) if (!cfq_class_idle(cfqq)) cfqd->last_end_request = now; - - if (sync) - RQ_CIC(rq)->last_end_request = now; } /* diff --git a/include/linux/iocontext.h b/include/linux/iocontext.h index 1fe9d78..9c4587b 100644 --- a/include/linux/iocontext.h +++ b/include/linux/iocontext.h @@ -39,7 +39,6 @@ struct cfq_io_context { struct io_context *ioc; - unsigned long last_end_request; sector_t last_request_pos; unsigned int seek_samples;