From patchwork Tue Aug 9 18:26:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Christie X-Patchwork-Id: 9271995 X-Patchwork-Delegate: christophe.varoqui@free.fr Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2D2546075A for ; Tue, 9 Aug 2016 18:30:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2250827E71 for ; Tue, 9 Aug 2016 18:30:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 15ED5283E2; Tue, 9 Aug 2016 18:30:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com [209.132.183.37]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AE91927E71 for ; Tue, 9 Aug 2016 18:30:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u79IQgp5045748; Tue, 9 Aug 2016 14:26:42 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u79IQfWS030699 for ; Tue, 9 Aug 2016 14:26:41 -0400 Received: from [10.10.48.241] (vpn-48-241.rdu2.redhat.com [10.10.48.241]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u79IQfhD010800; Tue, 9 Aug 2016 14:26:41 -0400 To: Christophe Varoqui References: <1470657710-28081-1-git-send-email-mchristi@redhat.com> From: Mike Christie Message-ID: <57AA2060.20708@redhat.com> Date: Tue, 9 Aug 2016 13:26:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-loop: dm-devel@redhat.com Cc: device-mapper development Subject: Re: [dm-devel] PATCH 0/4] multipath-tools: Ceph rbd support v2 X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Virus-Scanned: ClamAV using ClamSMTP On 08/09/2016 10:36 AM, Christophe Varoqui wrote: > Merged. > Thanks. > I think it is worth advertizing here that the build now requires rados.h. > Sorry about adding the silly dependency. How about the attached patch to make the rbd checker only be built if the user requests it. In the documentation for my use, I will describe how to build it. This way majority of users will not be bothered. > Thanks. > > On Mon, Aug 8, 2016 at 2:01 PM, Mike Christie wrote: > >> The following patches made over Christophe's tree today, >> add Ceph rbd support for handling blacklisted devices. >> >> >> This is not general support for rbd and multipath. There is >> no boot/root support and it does not support features like >> multibus. My use is for HA configurations, specifically for exporting >> rbd images through multiple LIO instances. In this case, we have one >> rbd instance that has the ceph rbd exclusive lock and it can send >> WRITE requests. If that host becomes unreachable, then another host >> will grab the lock, and blacklist the original host to prevent it from >> sending stale IO (when blacklisted IO will be failed by the OSD). >> >> To recover from that type of scenario, this patchset adds a repair() >> callout to the checker. If the path is in the PATH_DOWN state this >> callout can be used to fix it up. For my case, I am remapping >> the device to flush stale IO and cleanup the old lock, >> and then unblacklisting the path, so it can be used again. >> >> Changes since v1: >> - Drop ID_UID use and implemented sysfs getuid support. >> - Drop settings that were defaults and follow template. >> - Fix ceph auth/user. >> >> > > > > -- > dm-devel mailing list > dm-devel@redhat.com > https://www.redhat.com/mailman/listinfo/dm-devel > --- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel >From 4d0bfdfc032d4fabf0ac08ba105125ded168bd95 Mon Sep 17 00:00:00 2001 From: Mike Christie Date: Tue, 9 Aug 2016 13:19:41 -0500 Subject: [PATCH 1/1] checker: do not build rbd by default rbd is not a common driver and users will probably not have the tools/libs to use it. Make the rbd checker not built by default. Signed-off-by: Mike Christie --- libmultipath/checkers/Makefile | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libmultipath/checkers/Makefile b/libmultipath/checkers/Makefile index 5fd2099..aeb425f 100644 --- a/libmultipath/checkers/Makefile +++ b/libmultipath/checkers/Makefile @@ -11,8 +11,11 @@ LIBS= \ libcheckdirectio.so \ libcheckemc_clariion.so \ libcheckhp_sw.so \ - libcheckrdac.so \ - libcheckrbd.so + libcheckrdac.so + +ifneq ($(CHECKER_RBD),) +LIBS += libcheckrbd.so +endif CFLAGS += -I.. -- 2.7.2