NetApp Ontap

Commit Message

Xose Vazquez Perez June 24, 2016, 6:11 p.m. UTC

On 06/24/2016 07:52 PM, Martin George wrote:

> On 6/24/2016 1:12 AM, Xose Vazquez Perez wrote:
>>
>> And one question, should NETAPP/LUN.* and IBM/Nseries.* share the same options?
>>
> Yes, let them share the same options for now. I have some further updates on
> this which I will share later. Thanks.

Right now they are different:

--
dm-devel mailing list
[e-mail]
https://www.redhat.com/mailman/listinfo/dm-devel

Comments

Martin George June 27, 2016, 2:44 p.m. UTC | #1

On 6/24/2016 11:41 PM, Xose Vazquez Perez wrote:
> On 06/24/2016 07:52 PM, Martin George wrote:
>
>> On 6/24/2016 1:12 AM, Xose Vazquez Perez wrote:
>>>
>>> And one question, should NETAPP/LUN.* and IBM/Nseries.* share the same options?
>>>
>> Yes, let them share the same options for now. I have some further updates on
>> this which I will share later. Thanks.
>
> Right now they are different:
>
> --- netapp-ontap        2016-06-24 20:05:35.182539928 +0200
> +++ ibm-ontap   2016-06-24 20:05:26.750552635 +0200
> @@ -1,18 +1,14 @@
>          {
> -               .vendor        = "NETAPP",
> -               .product       = "LUN.*",
> -               .features      = "3 queue_if_no_path pg_init_retries 50",
> +               .vendor        = "IBM",
> +               .product       = "Nseries.*",
> +               .features      = "1 queue_if_no_path",
>                  .hwhandler     = DEFAULT_HWHANDLER,
>                  .pgpolicy      = GROUP_BY_PRIO,
>                  .pgfailback    = -FAILBACK_IMMEDIATE,
> -               .flush_on_last_del = FLUSH_ENABLED,
>                  .rr_weight     = RR_WEIGHT_NONE,
>                  .no_path_retry = NO_PATH_RETRY_UNDEF,
>                  .minio         = 128,
> -               .dev_loss      = MAX_DEV_LOSS_TMO,
> -               .checker_name  = TUR,
> +               .checker_name  = DIRECTIO,
>                  .prio_name     = PRIO_ONTAP,
>                  .prio_args     = NULL,
> -               .retain_hwhandler = RETAIN_HWHANDLER_ON,
> -               .detect_prio   = DETECT_PRIO_ON,
>

Yes, I know. I actually meant keeping these settings as it is for now. I 
will send a patch for NSeries later. Thanks.

-Martin George

--
dm-devel mailing list
[e-mail]
https://www.redhat.com/mailman/listinfo/dm-devel

Patch

--- netapp-ontap        2016-06-24 20:05:35.182539928 +0200
+++ ibm-ontap   2016-06-24 20:05:26.750552635 +0200
@@ -1,18 +1,14 @@ 
        {
-               .vendor        = "NETAPP",
-               .product       = "LUN.*",
-               .features      = "3 queue_if_no_path pg_init_retries 50",
+               .vendor        = "IBM",
+               .product       = "Nseries.*",
+               .features      = "1 queue_if_no_path",
                .hwhandler     = DEFAULT_HWHANDLER,
                .pgpolicy      = GROUP_BY_PRIO,
                .pgfailback    = -FAILBACK_IMMEDIATE,
-               .flush_on_last_del = FLUSH_ENABLED,
                .rr_weight     = RR_WEIGHT_NONE,
                .no_path_retry = NO_PATH_RETRY_UNDEF,
                .minio         = 128,
-               .dev_loss      = MAX_DEV_LOSS_TMO,
-               .checker_name  = TUR,
+               .checker_name  = DIRECTIO,
                .prio_name     = PRIO_ONTAP,
                .prio_args     = NULL,
-               .retain_hwhandler = RETAIN_HWHANDLER_ON,
-               .detect_prio   = DETECT_PRIO_ON,