diff mbox series

Fix possibility to redefine -D_FORTIFY_SOURCE macro.

Message ID 84bb9ebc-80fd-08a8-c326-c28cfedc8d81@suse.cz (mailing list archive)
State Not Applicable, archived
Delegated to: christophe varoqui
Headers show
Series Fix possibility to redefine -D_FORTIFY_SOURCE macro. | expand

Commit Message

Martin Liška April 6, 2022, 7:46 a.m. UTC 
As explained here:
https://github.com/opensvc/multipath-tools/issues/29

using -Wp,-D_FORTIFY_SOURCE cannot be redefined with
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3.
---
  Makefile.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin Wilck April 12, 2022, 9:58 a.m. UTC | #1 
On Wed, 2022-04-06 at 09:46 +0200, Martin Liška wrote:
> As explained here:
> https://github.com/opensvc/multipath-tools/issues/29
> 
> using -Wp,-D_FORTIFY_SOURCE cannot be redefined with
> -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3.

Looks good, please resend with Signed-off-by.

Thanks,
Martin

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
diff mbox series

Patch

diff --git a/Makefile.inc b/Makefile.inc
index d24da43e..cc170a2e 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -123,7 +123,7 @@  OPTFLAGS	:= -O2 -g $(STACKPROT) --param=ssp-buffer-size=4
  WARNFLAGS	:= -Werror -Wall -Wextra -Wformat=2 $(WFORMATOVERFLOW) -Werror=implicit-int \
  		  -Werror=implicit-function-declaration -Werror=format-security \
  		  $(WNOCLOBBERED) -Werror=cast-qual $(ERROR_DISCARDED_QUALIFIERS)
-CPPFLAGS	:= -Wp,-D_FORTIFY_SOURCE=2
+CPPFLAGS	:= -D_FORTIFY_SOURCE=2
  CFLAGS		:= --std=gnu99 $(CFLAGS) $(OPTFLAGS) $(WARNFLAGS) -pipe \
  		   -DBIN_DIR=\"$(bindir)\" -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\" \
  		   -MMD -MP