From patchwork Wed Dec 8 06:13:59 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chauhan, Vijay" X-Patchwork-Id: 389832 X-Patchwork-Delegate: christophe.varoqui@free.fr Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com [209.132.183.25]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oB86GAXC012636 for ; Wed, 8 Dec 2010 06:16:31 GMT Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oB86E0M2014024; Wed, 8 Dec 2010 01:14:01 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id oB86Dx9I015559 for ; Wed, 8 Dec 2010 01:13:59 -0500 Received: from mx1.redhat.com (ext-mx09.extmail.prod.ext.phx2.redhat.com [10.5.110.13]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oB86Dr5R010835 for ; Wed, 8 Dec 2010 01:13:54 -0500 Received: from na3sys009aog105.obsmtp.com (na3sys009aog105.obsmtp.com [74.125.149.75]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB86Dida003779 for ; Wed, 8 Dec 2010 01:13:45 -0500 Received: from source ([192.19.220.66]) (using TLSv1) by na3sys009aob105.postini.com ([74.125.148.12]) with SMTP ID DSNKTP8iGFUvvo5a0wrCs1kg3vgjRm4O6Jkl@postini.com; Tue, 07 Dec 2010 22:13:45 PST Received: from coshub01.lsi.com (135.142.2.64) by COSEDGE01.lsi.com (192.19.220.66) with Microsoft SMTP Server (TLS) id 8.3.106.1; Tue, 7 Dec 2010 23:14:31 -0700 Received: from inbexch02.lsi.com (135.36.98.40) by coshub01.lsi.com (135.142.2.64) with Microsoft SMTP Server (TLS) id 8.2.254.0; Tue, 7 Dec 2010 23:14:05 -0700 Received: from inbmail01.lsi.com ([135.36.98.64]) by inbexch02.lsi.com ([135.36.98.40]) with mapi; Wed, 8 Dec 2010 11:43:59 +0530 From: "Chauhan, Vijay" To: "christophe.varoqui@opensvc.com" Date: Wed, 8 Dec 2010 11:43:59 +0530 Thread-Topic: [dm-devel] rdac.c patch not quite right. Thread-Index: AcuWWcFt2aXPO2RIQ0yTaIVNuU7L8wAQzeVg Message-ID: References: <1291759024.4430.2.camel@zezette> In-Reply-To: <1291759024.4430.2.camel@zezette> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-RedHat-Spam-Score: -2.301 (RCVD_IN_DNSWL_MED,SPF_PASS) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Scanned-By: MIMEDefang 2.67 on 10.5.110.13 X-MIME-Autoconverted: from base64 to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id oB86Dx9I015559 X-loop: dm-devel@redhat.com Cc: device-mapper development Subject: Re: [dm-devel] rdac.c patch not quite right. X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Wed, 08 Dec 2010 06:16:32 +0000 (UTC) --- multipath-tools-orig/libmultipath/checkers/rdac.c 2010-12-06 02:59:40.000000000 -0600 +++ multipath-tools/libmultipath/checkers/rdac.c 2010-12-06 04:01:37.000000000 -0600 @@ -107,7 +107,7 @@ libcheck_check (struct checker * c) if (0 != do_inq(c->fd, 0xC9, &inq, sizeof(struct volume_access_inq))) { ret = PATH_DOWN; goto done; - } else if ((inq.PQ_PDT & 0x20) || (inq.PQ_PDT & 0x7f)) { + } else if (((inq.PQ_PDT & 0xE0) == 0x20) || (inq.PQ_PDT & 0x7f)) { /* LUN not connected*/ ret = PATH_DOWN; goto done;