From patchwork Fri Aug 28 14:18:39 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: babu moger X-Patchwork-Id: 44509 Received: from hormel.redhat.com (hormel1.redhat.com [209.132.177.33]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7SEJ91c017111 for ; Fri, 28 Aug 2009 14:19:09 GMT Received: from listman.util.phx.redhat.com (listman.util.phx.redhat.com [10.8.4.110]) by hormel.redhat.com (Postfix) with ESMTP id A558B6196F3; Fri, 28 Aug 2009 10:19:08 -0400 (EDT) Received: from int-mx03.intmail.prod.int.phx2.redhat.com (nat-pool.util.phx.redhat.com [10.8.5.200]) by listman.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n7SEJ7JZ027504 for ; Fri, 28 Aug 2009 10:19:07 -0400 Received: from mx1.redhat.com (ext-mx07.extmail.prod.ext.phx2.redhat.com [10.5.110.11]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7SEJ6io010533 for ; Fri, 28 Aug 2009 10:19:06 -0400 Received: from exprod7og105.obsmtp.com (exprod7og105.obsmtp.com [64.18.2.163]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7SEImM3023068 for ; Fri, 28 Aug 2009 10:18:49 -0400 Received: from source ([147.145.40.20]) by exprod7ob105.postini.com ([64.18.6.12]) with SMTP ID DSNKSpfnRT5ERRToOfCc1eLGD9h+m/d/Em/c@postini.com; Fri, 28 Aug 2009 07:18:54 PDT Received: from milmhbs0.lsil.com (mhbs.lsil.com [147.145.1.30]) by mail0.lsil.com (8.12.11/8.12.11) with ESMTP id n7SEIgxq025465; Fri, 28 Aug 2009 07:18:42 -0700 (PDT) Received: from coshub01.lsi.com (coshub01.co.lsil.com [172.21.36.64]) by milmhbs0.lsil.com (8.12.11/8.12.11) with ESMTP id n7SEIiRj014092; Fri, 28 Aug 2009 07:18:45 -0700 Received: from cosmail01.lsi.com ([172.21.36.24]) by coshub01.lsi.com ([172.21.36.64]) with mapi; Fri, 28 Aug 2009 08:18:41 -0600 From: "Moger, Babu" To: "'linux-scsi@vger.kernel.org'" Date: Fri, 28 Aug 2009 08:18:39 -0600 Thread-Topic: [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info Thread-Index: Acon6nCmxmucpBu5TUqJiLlXB73pyg== Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 X-Scanned-By: MIMEDefang 2.67 on 10.5.110.11 X-Scanned-By: MIMEDefang 2.39 X-RedHat-Spam-Score: -4 (RCVD_IN_DNSWL_MED) X-MIME-Autoconverted: from quoted-printable to 8bit by listman.util.phx.redhat.com id n7SEJ7JZ027504 X-loop: dm-devel@redhat.com Cc: "Dachepalli, Sudhir" , "'dm-devel@redhat.com'" , "Chauhan, Vijay" , "Stankey, Robert" Subject: [dm-devel] [PATCH][RESUBMIT] scsi_dh_rdac: Fix for returning correct mode select cmd return info X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.5 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com The function mode_select_handle_sense returns SCSI_DH_OK even when there is a sense code which is incorrect. Removing it so that it returns SCSI_DH_IO when there is sense that is not handled by this function. Signed-off-by: Babu Moger Reviewed-by: Vijay Chauhan Reviewed-by: Bob Stankey Reviewed-by: Chandra Seetharaman --- -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel --- linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c.orig 2009-08-22 06:20:45.000000000 -0500 +++ linux-2.6.31-rc5/drivers/scsi/device_handler/scsi_dh_rdac.c 2009-08-22 06:18:36.000000000 -0500 @@ -455,8 +455,6 @@ static int mode_select_handle_sense(stru if (!ret) goto done; - err = SCSI_DH_OK; - switch (sense_hdr.sense_key) { case NO_SENSE: case ABORTED_COMMAND: