From patchwork Tue Jun 23 19:50:13 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charlie Brady X-Patchwork-Id: 32081 X-Patchwork-Delegate: christophe.varoqui@free.fr Received: from hormel.redhat.com (hormel1.redhat.com [209.132.177.33]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n5O4BF6W020500 for ; Wed, 24 Jun 2009 04:11:16 GMT Received: from listman.util.phx.redhat.com (listman.util.phx.redhat.com [10.8.4.110]) by hormel.redhat.com (Postfix) with ESMTP id 5A1996193B1; Wed, 24 Jun 2009 00:11:14 -0400 (EDT) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by listman.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n5O4BCFm002740 for ; Wed, 24 Jun 2009 00:11:12 -0400 Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5O4BBcV024399 for ; Wed, 24 Jun 2009 00:11:11 -0400 Received: from charlieb.ott.istop.com (charlieb.ott.istop.com [66.11.174.133]) by mx3.redhat.com (8.13.8/8.13.8) with SMTP id n5O4AtNm017705 for ; Wed, 24 Jun 2009 00:10:57 -0400 Received: (qmail 18753 invoked by uid 453); 23 Jun 2009 19:50:14 -0000 Received: from e-smith.charlieb.ott.istop.com (HELO e-smith.charlieb.ott.istop.com) (192.168.117.1) by charlieb.ott.istop.com (qpsmtpd/0.40) with ESMTP; Tue, 23 Jun 2009 15:50:14 -0400 Date: Tue, 23 Jun 2009 15:50:13 -0400 (EDT) From: Charlie Brady X-X-Sender: charlieb@e-smith.charlieb.ott.istop.com To: dm-devel@redhat.com Message-ID: MIME-Version: 1.0 X-RedHat-Spam-Score: 0 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-Scanned-By: MIMEDefang 2.63 on 172.16.48.32 X-loop: dm-devel@redhat.com Subject: [dm-devel] RDAC path checker status change messages X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.5 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com It seems to me that this patch is required, to fix a problem with "path down" messages being logged when the path transitions to up (and presumably ghost). --- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel --- libcheckers/rdac.c.orig 2009-06-23 15:38:05.371422000 -0400 +++ libcheckers/rdac.c 2009-06-23 15:39:28.020843000 -0400 @@ -105,5 +105,12 @@ return PATH_DOWN; } - return ((inq.avtcvp & 0x1) ? PATH_UP : PATH_GHOST); + if (inq.avtcvp & 0x1) { + MSG(c, MSG_RDAC_UP); + return PATH_UP; + } + else { + MSG(c, MSG_RDAC_GHOST); + return PATH_GHOST; + } }