From patchwork Thu Jun 25 17:50:51 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Charlie Brady X-Patchwork-Id: 32430 X-Patchwork-Delegate: christophe.varoqui@free.fr Received: from hormel.redhat.com (hormel1.redhat.com [209.132.177.33]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n5PHpmAr018105 for ; Thu, 25 Jun 2009 17:51:48 GMT Received: from listman.util.phx.redhat.com (listman.util.phx.redhat.com [10.8.4.110]) by hormel.redhat.com (Postfix) with ESMTP id AF27961A02F; Thu, 25 Jun 2009 13:51:47 -0400 (EDT) Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by listman.util.phx.redhat.com (8.13.1/8.13.1) with ESMTP id n5PHpkGI003464 for ; Thu, 25 Jun 2009 13:51:46 -0400 Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5PHpjvH010165 for ; Thu, 25 Jun 2009 13:51:45 -0400 Received: from mail.ncf.ca (saruman.ncf.ca [134.117.136.37]) by mx3.redhat.com (8.13.8/8.13.8) with ESMTP id n5PHovem022483 for ; Thu, 25 Jun 2009 13:50:58 -0400 Received: from charlieb.ott.istop.com (206-248-169-175.dsl.ncf.ca [206.248.169.175]) by mail.ncf.ca (Postfix) with SMTP id 2D9B1439C2 for ; Thu, 25 Jun 2009 13:50:57 -0400 (EDT) Received: (qmail 4516 invoked by uid 453); 25 Jun 2009 17:50:51 -0000 Received: from e-smith.charlieb.ott.istop.com (HELO e-smith.charlieb.ott.istop.com) (192.168.117.1) by charlieb.ott.istop.com (qpsmtpd/0.40) with ESMTP; Thu, 25 Jun 2009 13:50:51 -0400 Date: Thu, 25 Jun 2009 13:50:51 -0400 (EDT) From: Charlie Brady X-X-Sender: charlieb@e-smith.charlieb.ott.istop.com To: device-mapper development Message-ID: MIME-Version: 1.0 X-RedHat-Spam-Score: 0 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-Scanned-By: MIMEDefang 2.63 on 172.16.48.32 X-loop: dm-devel@redhat.com Subject: [dm-devel] [PATCH multipath-tools-0.4.7.rhel5.13 1/1] multipathd excessive path checker logging X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.5 Precedence: junk Reply-To: device-mapper development List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com multipathd logs a path checker message whenever state changes. But it also logs every non-changed message when verbosity is >=4 and newstate is PATH_UP or PATH_GHOST, and every non-changed message when verbosity is >= 2 and newstate is PATH_DOWN. I believe that the message should only be logged, once, when state changes. Signed-off-by: Charlie Brady --- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel --- multipath-tools-0.4.7.rhel5.13/multipathd/main.c 2009-06-25 13:32:57.248455000 -0400 +++ mezzanine_patched_multipath-tools-0.4.7.rhel5.13/multipathd/main.c 2009-06-25 13:32:12.968639000 -0400 @@ -1041,7 +1041,6 @@ enable_group(pp); } else if (newstate == PATH_UP || newstate == PATH_GHOST) { - LOG_MSG(4, checker_message(&pp->checker)); /* * double the next check delay. * max at conf->max_checkint @@ -1055,8 +1054,6 @@ condlog(4, "%s: delay next check %is", pp->dev_t, pp->tick); } - else if (newstate == PATH_DOWN) - LOG_MSG(2, checker_message(&pp->checker)); pp->state = newstate;