| Message ID | alpine.LRH.2.02.1402131343110.22991@file01.intranet.prod.int.rdu2.redhat.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
On Thu, Feb 13 2014 at 1:43pm -0500, Mikulas Patocka <mpatocka@redhat.com> wrote: > Make the function dm_table_alloc_md_mempools static because it is not > called from another module. Doesn't the same apply to dm_table_free_md_mempools? -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On Thu, 13 Feb 2014, Mike Snitzer wrote: > On Thu, Feb 13 2014 at 1:43pm -0500, > Mikulas Patocka <mpatocka@redhat.com> wrote: > > > Make the function dm_table_alloc_md_mempools static because it is not > > called from another module. > > Doesn't the same apply to dm_table_free_md_mempools? No, it is called from dm.c and defined in dm-table.c Mikulas -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
On Thu, Feb 13 2014 at 2:19pm -0500, Mikulas Patocka <mpatocka@redhat.com> wrote: > > > On Thu, 13 Feb 2014, Mike Snitzer wrote: > > > On Thu, Feb 13 2014 at 1:43pm -0500, > > Mikulas Patocka <mpatocka@redhat.com> wrote: > > > > > Make the function dm_table_alloc_md_mempools static because it is not > > > called from another module. > > > > Doesn't the same apply to dm_table_free_md_mempools? > > No, it is called from dm.c and defined in dm-table.c Ah, yeah.. I was thinking of exports.. sorry. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
Index: linux-3.14-rc1/drivers/md/dm-table.c =================================================================== --- linux-3.14-rc1.orig/drivers/md/dm-table.c 2014-02-06 13:37:06.000000000 +0100 +++ linux-3.14-rc1/drivers/md/dm-table.c 2014-02-06 13:37:17.000000000 +0100 @@ -957,7 +957,7 @@ bool dm_table_request_based(struct dm_ta return dm_table_get_type(t) == DM_TYPE_REQUEST_BASED; } -int dm_table_alloc_md_mempools(struct dm_table *t) +static int dm_table_alloc_md_mempools(struct dm_table *t) { unsigned type = dm_table_get_type(t); unsigned per_bio_data_size = 0; Index: linux-3.14-rc1/drivers/md/dm.h =================================================================== --- linux-3.14-rc1.orig/drivers/md/dm.h 2014-02-06 13:36:53.000000000 +0100 +++ linux-3.14-rc1/drivers/md/dm.h 2014-02-06 13:37:01.000000000 +0100 @@ -73,7 +73,6 @@ unsigned dm_table_get_type(struct dm_tab struct target_type *dm_table_get_immutable_target_type(struct dm_table *t); bool dm_table_request_based(struct dm_table *t); bool dm_table_supports_discards(struct dm_table *t); -int dm_table_alloc_md_mempools(struct dm_table *t); void dm_table_free_md_mempools(struct dm_table *t); struct dm_md_mempools *dm_table_get_md_mempools(struct dm_table *t);
Make the function dm_table_alloc_md_mempools static because it is not called from another module. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> --- drivers/md/dm-table.c | 2 +- drivers/md/dm.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel