mbox series

[v1,00/15] Add RDMA memory mode support for mediatek SOC MT2712

Message ID 1532420235-22268-1-git-send-email-stu.hsieh@mediatek.com (mailing list archive)
Headers show
Series Add RDMA memory mode support for mediatek SOC MT2712 | expand

Message

Stu Hsieh July 24, 2018, 8:17 a.m. UTC
This patch series add RDMA memory mode support for mediatek SOC MT2712.
MT2712 has three display data path, including three HW engine,
two OVL and one RDMA.

The RDMA used in third ddp and it need to be set memory mode,
then RDMA could read data from memory and output to panel.

Stu Hsieh (15):
  drm/mediatek: add connection from RDMA0 to DPI1
  drm/mediatek: add connection from RDMA0 to DSI1
  drm/mediatek: add connection from RDMA1 to DSI0
  drm/mediatek: add connection from RDMA2 to DSI0
  drm/mediatek: add RDMA memory mode for crtc created
  drm/mediatek: add memory mode for RDMA
  drm/mediatek: add layer config to set RDMA for plane setting
  drm/mediatek: add RGB color format support for RDMA
  drm/mediatek: add YUYV/UYVY color format support for RDMA
  drm/mediatek: add drm_device in RDMA for mamory mode to reaquest
    buffer
  drm/mediatek: add dummy buffer for RDMA memory mode
  drm/mediatek: add layer number condition for RDMA to control plane
  drm/mediatek: Update some variable name from ovl to comp
  drm/mediatek: fixed the error value for add DSI1 in mutex
  drm/mediatek: fixed connection from RDMA2 to DSI1

 drivers/gpu/drm/mediatek/mtk_disp_rdma.c    | 122 +++++++++++++++++++++++++++-
 drivers/gpu/drm/mediatek/mtk_drm_crtc.c     |  59 +++++++++-----
 drivers/gpu/drm/mediatek/mtk_drm_crtc.h     |   4 +-
 drivers/gpu/drm/mediatek/mtk_drm_ddp.c      |  20 ++++-
 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h |   2 +
 5 files changed, 181 insertions(+), 26 deletions(-)

Comments

CK Hu (胡俊光) July 25, 2018, 1:39 a.m. UTC | #1
Hi, Stu:

It looks like the series is a bug fix of [1]. In [1], you create third
crtc but it does not work unless apply this series. So for all the
patches in this series, you should refer to [2] to add 'Fixes:' and
'Cc:' in commit message.


[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=e6ab087a224fd7bcf712db698fbade673cc9addd
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=83ba62bc700bab710b22be3a1bf6cf973f754273

Regards,
CK

On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote:
> This patch series add RDMA memory mode support for mediatek SOC MT2712.
> MT2712 has three display data path, including three HW engine,
> two OVL and one RDMA.
> 
> The RDMA used in third ddp and it need to be set memory mode,
> then RDMA could read data from memory and output to panel.
> 
> Stu Hsieh (15):
>   drm/mediatek: add connection from RDMA0 to DPI1
>   drm/mediatek: add connection from RDMA0 to DSI1
>   drm/mediatek: add connection from RDMA1 to DSI0
>   drm/mediatek: add connection from RDMA2 to DSI0
>   drm/mediatek: add RDMA memory mode for crtc created
>   drm/mediatek: add memory mode for RDMA
>   drm/mediatek: add layer config to set RDMA for plane setting
>   drm/mediatek: add RGB color format support for RDMA
>   drm/mediatek: add YUYV/UYVY color format support for RDMA
>   drm/mediatek: add drm_device in RDMA for mamory mode to reaquest
>     buffer
>   drm/mediatek: add dummy buffer for RDMA memory mode
>   drm/mediatek: add layer number condition for RDMA to control plane
>   drm/mediatek: Update some variable name from ovl to comp
>   drm/mediatek: fixed the error value for add DSI1 in mutex
>   drm/mediatek: fixed connection from RDMA2 to DSI1
> 
>  drivers/gpu/drm/mediatek/mtk_disp_rdma.c    | 122 +++++++++++++++++++++++++++-
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.c     |  59 +++++++++-----
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.h     |   4 +-
>  drivers/gpu/drm/mediatek/mtk_drm_ddp.c      |  20 ++++-
>  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h |   2 +
>  5 files changed, 181 insertions(+), 26 deletions(-)
>
Stu Hsieh Aug. 2, 2018, 11:29 a.m. UTC | #2
Hi, CK:

On Wed, 2018-07-25 at 09:39 +0800, CK Hu wrote:
> Hi, Stu:
> 
> It looks like the series is a bug fix of [1]. In [1], you create third
> crtc but it does not work unless apply this series. So for all the
> patches in this series, you should refer to [2] to add 'Fixes:' and
> 'Cc:' in commit message.
> 
> 
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=e6ab087a224fd7bcf712db698fbade673cc9addd
> [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=83ba62bc700bab710b22be3a1bf6cf973f754273
> 
> Regards,
> CK
> 

OK

Regards,
Stu

> On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote:
> > This patch series add RDMA memory mode support for mediatek SOC MT2712.
> > MT2712 has three display data path, including three HW engine,
> > two OVL and one RDMA.
> > 
> > The RDMA used in third ddp and it need to be set memory mode,
> > then RDMA could read data from memory and output to panel.
> > 
> > Stu Hsieh (15):
> >   drm/mediatek: add connection from RDMA0 to DPI1
> >   drm/mediatek: add connection from RDMA0 to DSI1
> >   drm/mediatek: add connection from RDMA1 to DSI0
> >   drm/mediatek: add connection from RDMA2 to DSI0
> >   drm/mediatek: add RDMA memory mode for crtc created
> >   drm/mediatek: add memory mode for RDMA
> >   drm/mediatek: add layer config to set RDMA for plane setting
> >   drm/mediatek: add RGB color format support for RDMA
> >   drm/mediatek: add YUYV/UYVY color format support for RDMA
> >   drm/mediatek: add drm_device in RDMA for mamory mode to reaquest
> >     buffer
> >   drm/mediatek: add dummy buffer for RDMA memory mode
> >   drm/mediatek: add layer number condition for RDMA to control plane
> >   drm/mediatek: Update some variable name from ovl to comp
> >   drm/mediatek: fixed the error value for add DSI1 in mutex
> >   drm/mediatek: fixed connection from RDMA2 to DSI1
> > 
> >  drivers/gpu/drm/mediatek/mtk_disp_rdma.c    | 122 +++++++++++++++++++++++++++-
> >  drivers/gpu/drm/mediatek/mtk_drm_crtc.c     |  59 +++++++++-----
> >  drivers/gpu/drm/mediatek/mtk_drm_crtc.h     |   4 +-
> >  drivers/gpu/drm/mediatek/mtk_drm_ddp.c      |  20 ++++-
> >  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h |   2 +
> >  5 files changed, 181 insertions(+), 26 deletions(-)
> > 
> 
>