| Message ID | 1556195748-11106-1-git-send-email-claudiu.beznea@microchip.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add LCD support for SAM9X60 | expand |
Hi Thierry. > pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM OK to add the "pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM" patch via drm-misc? Then we can add all 6 patches in one go. Sam (Kept remaining of mail for reference) > > Hi, > > These patches adds support for SAM9X60's LCD controller. > > First patches add option to specify if controller clock source is fixed. > Second patch avoid a variable initialization in atmel_hlcdc_crtc_mode_set_nofb(). > The 3rd add compatibles in pwm-atmel-hlcdc driver. > The 4th patch enables sys_clk in probe since SAM9X60 needs this. > Specific support was added also in suspend/resume hooks. > The 5th patch adds SAM9X60's LCD configuration and enabled it. > > I took the changes of this series and introduced also a fix > (this is the 6th patch in this series) - if you want to send it separately > I would gladly do it. > > I resend this to also include Lee Jones for pwm-atmel-hlcdc changes. > > Thank you, > Claudiu Beznea > > Changes in v3: > - keep compatible string on patch 3/6 on a single line (I keep here a tab > in front of ".compatible" to be aligned with the rest of the code in > atmel_hlcdc_dt_ids[]) > - patches 4/7 and 3/7 from v2 were applied so remove them from this version > - add a fix for atmel_hlcdc (patch 6/6) > > Changes in v2: > - use "|" operator in patch 1/7 to set ATMEL_HLCDC_CLKSEL on cfg > - collect Acked-by, Reviewed-by tags > > Claudiu Beznea (4): > drm: atmel-hlcdc: add config option for clock selection > drm: atmel-hlcdc: avoid initializing cfg with zero > pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM > drm/atmel-hclcdc: revert shift by 8 > > Sandeep Sheriker Mallikarjun (2): > drm: atmel-hlcdc: enable sys_clk during initalization. > drm: atmel-hlcdc: add sam9x60 LCD controller > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 18 ++-- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 120 +++++++++++++++++++++++- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 + > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- > drivers/pwm/pwm-atmel-hlcdc.c | 1 + > 5 files changed, 132 insertions(+), 11 deletions(-) > > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 18 ++-- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 120 +++++++++++++++++++++++- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 + > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- > drivers/pwm/pwm-atmel-hlcdc.c | 1 + > 5 files changed, 132 insertions(+), 11 deletions(-) Not sure why I am receiving this set. Could you please drop me from future submissions.
On 08.05.2019 09:23, Lee Jones wrote: > External E-Mail > > >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 18 ++-- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 120 +++++++++++++++++++++++- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 + >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- >> drivers/pwm/pwm-atmel-hlcdc.c | 1 + >> 5 files changed, 132 insertions(+), 11 deletions(-) > > Not sure why I am receiving this set. Thierry suggested in v1 of this series to take pwm-atmel-hlcdc.c changes though MFD tree [1]. Then, in v2 you ask me to do update a bit the changes in pwm-atmel-hlcdc.c [2]. I send all the patches in one shot so that the context to be more obvious. Sorry for the noise, if any. [1] https://lore.kernel.org/lkml/20190304110517.GB5121@ulmo/ [2] https://lore.kernel.org/lkml/20190425083132.GD14758@dell/ > Could you please drop me from future submissions. >
Hi Sam, On 07.05.2019 21:27, Sam Ravnborg wrote: > External E-Mail > > > Hi Thierry. > >> pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM > OK to add the "pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM" > patch via drm-misc? > Then we can add all 6 patches in one go. Since we don't have an answer from Thierry till now, do you think it could be feasible to take the rest of the patches in this series? After that I will re-send the PWM patch to PWM list. Thank you, Claudiu Beznea > > Sam > > (Kept remaining of mail for reference) >> >> Hi, >> >> These patches adds support for SAM9X60's LCD controller. >> >> First patches add option to specify if controller clock source is fixed. >> Second patch avoid a variable initialization in atmel_hlcdc_crtc_mode_set_nofb(). >> The 3rd add compatibles in pwm-atmel-hlcdc driver. >> The 4th patch enables sys_clk in probe since SAM9X60 needs this. >> Specific support was added also in suspend/resume hooks. >> The 5th patch adds SAM9X60's LCD configuration and enabled it. >> >> I took the changes of this series and introduced also a fix >> (this is the 6th patch in this series) - if you want to send it separately >> I would gladly do it. >> >> I resend this to also include Lee Jones for pwm-atmel-hlcdc changes. >> >> Thank you, >> Claudiu Beznea >> >> Changes in v3: >> - keep compatible string on patch 3/6 on a single line (I keep here a tab >> in front of ".compatible" to be aligned with the rest of the code in >> atmel_hlcdc_dt_ids[]) >> - patches 4/7 and 3/7 from v2 were applied so remove them from this version >> - add a fix for atmel_hlcdc (patch 6/6) >> >> Changes in v2: >> - use "|" operator in patch 1/7 to set ATMEL_HLCDC_CLKSEL on cfg >> - collect Acked-by, Reviewed-by tags >> >> Claudiu Beznea (4): >> drm: atmel-hlcdc: add config option for clock selection >> drm: atmel-hlcdc: avoid initializing cfg with zero >> pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM >> drm/atmel-hclcdc: revert shift by 8 >> >> Sandeep Sheriker Mallikarjun (2): >> drm: atmel-hlcdc: enable sys_clk during initalization. >> drm: atmel-hlcdc: add sam9x60 LCD controller >> >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 18 ++-- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 120 +++++++++++++++++++++++- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 + >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- >> drivers/pwm/pwm-atmel-hlcdc.c | 1 + >> 5 files changed, 132 insertions(+), 11 deletions(-) >> >> -- >> 2.7.4 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >
Hi Claudiu. On Tue, Jun 04, 2019 at 04:18:33PM +0000, Claudiu.Beznea@microchip.com wrote: > Hi Sam, > > On 07.05.2019 21:27, Sam Ravnborg wrote: > > External E-Mail > > > > > > Hi Thierry. > > > >> pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM > > OK to add the "pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM" > > patch via drm-misc? > > Then we can add all 6 patches in one go. > > Since we don't have an answer from Thierry till now, do you think it could > be feasible to take the rest of the patches in this series? After that I > will re-send the PWM patch to PWM list. Thanks for the reminder. Patches 1,2 and 4,5,6 applied to drm-misc-next. Reworded changelog a bit in patch 6. Sam
On Thu, 25 Apr 2019, Claudiu.Beznea@microchip.com wrote: > From: Claudiu Beznea <claudiu.beznea@microchip.com> > > Hi, > > These patches adds support for SAM9X60's LCD controller. > > First patches add option to specify if controller clock source is fixed. > Second patch avoid a variable initialization in atmel_hlcdc_crtc_mode_set_nofb(). > The 3rd add compatibles in pwm-atmel-hlcdc driver. > The 4th patch enables sys_clk in probe since SAM9X60 needs this. > Specific support was added also in suspend/resume hooks. > The 5th patch adds SAM9X60's LCD configuration and enabled it. > > I took the changes of this series and introduced also a fix > (this is the 6th patch in this series) - if you want to send it separately > I would gladly do it. > > I resend this to also include Lee Jones for pwm-atmel-hlcdc changes. > > Thank you, > Claudiu Beznea > > Changes in v3: > - keep compatible string on patch 3/6 on a single line (I keep here a tab > in front of ".compatible" to be aligned with the rest of the code in > atmel_hlcdc_dt_ids[]) > - patches 4/7 and 3/7 from v2 were applied so remove them from this version > - add a fix for atmel_hlcdc (patch 6/6) > > Changes in v2: > - use "|" operator in patch 1/7 to set ATMEL_HLCDC_CLKSEL on cfg > - collect Acked-by, Reviewed-by tags > > Claudiu Beznea (4): > drm: atmel-hlcdc: add config option for clock selection > drm: atmel-hlcdc: avoid initializing cfg with zero > pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM > drm/atmel-hclcdc: revert shift by 8 > > Sandeep Sheriker Mallikarjun (2): > drm: atmel-hlcdc: enable sys_clk during initalization. > drm: atmel-hlcdc: add sam9x60 LCD controller > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 18 ++-- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 120 +++++++++++++++++++++++- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 + > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- > drivers/pwm/pwm-atmel-hlcdc.c | 1 + > 5 files changed, 132 insertions(+), 11 deletions(-) Why is this being sent to me?
On 05.06.2019 00:54, Sam Ravnborg wrote: > Hi Claudiu. > > On Tue, Jun 04, 2019 at 04:18:33PM +0000, Claudiu.Beznea@microchip.com wrote: >> Hi Sam, >> >> On 07.05.2019 21:27, Sam Ravnborg wrote: >>> External E-Mail >>> >>> >>> Hi Thierry. >>> >>>> pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM >>> OK to add the "pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM" >>> patch via drm-misc? >>> Then we can add all 6 patches in one go. >> >> Since we don't have an answer from Thierry till now, do you think it could >> be feasible to take the rest of the patches in this series? After that I >> will re-send the PWM patch to PWM list. > > Thanks for the reminder. > > Patches 1,2 and 4,5,6 applied to drm-misc-next. > > Reworded changelog a bit in patch 6. Thank you, Claudiu > > Sam >
On 05.06.2019 09:49, Lee Jones wrote: > External E-Mail > > > On Thu, 25 Apr 2019, Claudiu.Beznea@microchip.com wrote: > >> From: Claudiu Beznea <claudiu.beznea@microchip.com> >> >> Hi, >> >> These patches adds support for SAM9X60's LCD controller. >> >> First patches add option to specify if controller clock source is fixed. >> Second patch avoid a variable initialization in atmel_hlcdc_crtc_mode_set_nofb(). >> The 3rd add compatibles in pwm-atmel-hlcdc driver. >> The 4th patch enables sys_clk in probe since SAM9X60 needs this. >> Specific support was added also in suspend/resume hooks. >> The 5th patch adds SAM9X60's LCD configuration and enabled it. >> >> I took the changes of this series and introduced also a fix >> (this is the 6th patch in this series) - if you want to send it separately >> I would gladly do it. >> >> I resend this to also include Lee Jones for pwm-atmel-hlcdc changes. >> >> Thank you, >> Claudiu Beznea >> >> Changes in v3: >> - keep compatible string on patch 3/6 on a single line (I keep here a tab >> in front of ".compatible" to be aligned with the rest of the code in >> atmel_hlcdc_dt_ids[]) >> - patches 4/7 and 3/7 from v2 were applied so remove them from this version >> - add a fix for atmel_hlcdc (patch 6/6) >> >> Changes in v2: >> - use "|" operator in patch 1/7 to set ATMEL_HLCDC_CLKSEL on cfg >> - collect Acked-by, Reviewed-by tags >> >> Claudiu Beznea (4): >> drm: atmel-hlcdc: add config option for clock selection >> drm: atmel-hlcdc: avoid initializing cfg with zero >> pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM >> drm/atmel-hclcdc: revert shift by 8 >> >> Sandeep Sheriker Mallikarjun (2): >> drm: atmel-hlcdc: enable sys_clk during initalization. >> drm: atmel-hlcdc: add sam9x60 LCD controller >> >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 18 ++-- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 120 +++++++++++++++++++++++- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 + >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- >> drivers/pwm/pwm-atmel-hlcdc.c | 1 + >> 5 files changed, 132 insertions(+), 11 deletions(-) > > Why is this being sent to me? Sorry, you were in the original "to" list due to changes that you asked for in v2 on mfd part. Thierry suggested in v1 of this series to take pwm-atmel-hlcdc.c changes though MFD tree [1]. Then, in v2 you ask me to do update a bit the changes in pwm-atmel-hlcdc.c [2]. And in this reply I forgot to remove your email as you previously suggested. My bad! Thank you, Claudiu Beznea [1] https://lore.kernel.org/lkml/20190304110517.GB5121@ulmo/ [2] https://lore.kernel.org/lkml/20190425083132.GD14758@dell/ >
From: Claudiu Beznea <claudiu.beznea@microchip.com> Hi, These patches adds support for SAM9X60's LCD controller. First patches add option to specify if controller clock source is fixed. Second patch avoid a variable initialization in atmel_hlcdc_crtc_mode_set_nofb(). The 3rd add compatibles in pwm-atmel-hlcdc driver. The 4th patch enables sys_clk in probe since SAM9X60 needs this. Specific support was added also in suspend/resume hooks. The 5th patch adds SAM9X60's LCD configuration and enabled it. I took the changes of this series and introduced also a fix (this is the 6th patch in this series) - if you want to send it separately I would gladly do it. I resend this to also include Lee Jones for pwm-atmel-hlcdc changes. Thank you, Claudiu Beznea Changes in v3: - keep compatible string on patch 3/6 on a single line (I keep here a tab in front of ".compatible" to be aligned with the rest of the code in atmel_hlcdc_dt_ids[]) - patches 4/7 and 3/7 from v2 were applied so remove them from this version - add a fix for atmel_hlcdc (patch 6/6) Changes in v2: - use "|" operator in patch 1/7 to set ATMEL_HLCDC_CLKSEL on cfg - collect Acked-by, Reviewed-by tags Claudiu Beznea (4): drm: atmel-hlcdc: add config option for clock selection drm: atmel-hlcdc: avoid initializing cfg with zero pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM drm/atmel-hclcdc: revert shift by 8 Sandeep Sheriker Mallikarjun (2): drm: atmel-hlcdc: enable sys_clk during initalization. drm: atmel-hlcdc: add sam9x60 LCD controller drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 18 ++-- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 120 +++++++++++++++++++++++- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 + drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- drivers/pwm/pwm-atmel-hlcdc.c | 1 + 5 files changed, 132 insertions(+), 11 deletions(-)