Message ID | 1565867073-24746-1-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
---|---|
Headers | show |
Series | Add dual-LVDS panel support to EK874 | expand |
Hi Laurent, Thank you for your feedback! > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart > Sent: 15 August 2019 12:55 > Subject: Re: [PATCH v2 6/9] drm: rcar-du: lvds: Fix companion's mode > > Hi Fabrizio, > > Thank you for the patch. > > On Thu, Aug 15, 2019 at 12:04:30PM +0100, Fabrizio Castro wrote: > > The companion encoder needs to be told to use the same > > mode as the primary encoder. > > > > Fixes: e9e8798ab7b8 ("drm: rcar-du: lvds: Add support for dual-link mode") > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > --- > > v1->v2: > > * reworked according to Laurent's feedback > > > > drivers/gpu/drm/rcar-du/rcar_lvds.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > > index 3fe0b86..41d28f4 100644 > > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > > @@ -603,6 +603,11 @@ static void rcar_lvds_mode_set(struct drm_bridge *bridge, > > lvds->display_mode = *adjusted_mode; > > > > rcar_lvds_get_lvds_mode(lvds); > > + if (lvds->companion) { > > + struct rcar_lvds *companion_lvds = bridge_to_rcar_lvds( > > + lvds->companion); > > + companion_lvds->mode = lvds->mode; > > How about calling rcar_lvds_mode_set() on the companion instead ? Can do, will send a new version. Cheers, Fab > > > + } > > } > > > > static int rcar_lvds_attach(struct drm_bridge *bridge) > > -- > Regards, > > Laurent Pinchart
Hi Sam, Thank you for your feedback! > From: Sam Ravnborg <sam@ravnborg.org> > Sent: 15 August 2019 15:16 > Subject: Re: [PATCH v2 0/9] Add dual-LVDS panel support to EK874 > > Hi Fabrizio > > > it appears that Rob has been busy converting the dt-bindings relevant to this > > series, and his changes are now found in linux-next. Most notably > > Documentation/devicetree/bindings/display/panel/panel-lvds.txt has now become > > Documentation/devicetree/bindings/display/panel/lvds.yaml > > > > You have already taken patch: > > https://patchwork.kernel.org/patch/11072749/ > > > > as such the patch I am sending you is still related to: > > Documentation/devicetree/bindings/display/panel/panel-lvds.txt > > > > Patch "dt-bindings: display: Add bindings for Advantech IDK-2121WR" is still > > assuming the format is .txt, as I am not too sure about what the protocol is in > > this case? Shall we take this patch and convert it later to .yaml or shall I > > convert it to .yaml straight away? > > > > Please, let me know what's the best course of action. > > It is preferred that all new display and panel bindings uses the new > meta-schema format. > And that the writers uses the available tools to verify the bindings > submission. > This is one way to avoid simple mistakes in examples. Will give the meta-schema format a shot. Thanks, Fab > > Sam