mbox series

[0/3] add checks against divide error

Message ID 1627179054-29903-1-git-send-email-zheyuma97@gmail.com (mailing list archive)
Headers show
Series add checks against divide error | expand

Message

Zheyu Ma July 25, 2021, 2:10 a.m. UTC 
Zheyu Ma (3):
  video: fbdev: kyro: add a check against divide error
  video: fbdev: riva: add a check against divide error
  video: fbdev: asiliantfb: add a check against divide error

 drivers/video/fbdev/asiliantfb.c | 3 +++
 drivers/video/fbdev/kyro/fbdev.c | 3 +++
 drivers/video/fbdev/riva/fbdev.c | 3 +++
 3 files changed, 9 insertions(+)

Comments

Sam Ravnborg July 25, 2021, 8:18 p.m. UTC | #1 
Hi Zheyu,

On Sun, Jul 25, 2021 at 02:10:51AM +0000, Zheyu Ma wrote:
> Zheyu Ma (3):
>   video: fbdev: kyro: add a check against divide error
>   video: fbdev: riva: add a check against divide error
>   video: fbdev: asiliantfb: add a check against divide error

I would prefer something a bit more descriptive - like:

video: fbdev: <driver>: Error out if pixclk equals zero

Please respin so we have something like the above.
I looked briefly at the patches, they looked fine.

Thanks,
	Sam
Zheyu Ma July 26, 2021, 9:42 a.m. UTC | #2 
On Mon, Jul 26, 2021 at 4:18 AM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Zheyu,
>
> On Sun, Jul 25, 2021 at 02:10:51AM +0000, Zheyu Ma wrote:
> > Zheyu Ma (3):
> >   video: fbdev: kyro: add a check against divide error
> >   video: fbdev: riva: add a check against divide error
> >   video: fbdev: asiliantfb: add a check against divide error
>
> I would prefer something a bit more descriptive - like:
>
> video: fbdev: <driver>: Error out if pixclk equals zero
>
> Please respin so we have something like the above.
> I looked briefly at the patches, they looked fine.

Thanks for your valuable comments, I will re-edit the commit log and
send the patches.

Regards,
Zheyu Ma