| Message ID | 1675092092-26412-1-git-send-email-quic_kalyant@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Reserve dspps based on user request | expand |
On 30/01/2023 17:21, Kalyan Thota wrote: > This series will enable color features on sc7280 target which has primary panel as eDP > > The series removes dspp allocation based on encoder type and allows the dspp reservation > based on user request via ctm. > > The series will release/reserve the dpu resources when ever there is a topology change > to suit the new requirements. Nit: the subject of the cover letter should include the version, if you are including one into the individual patches Subject. > > Kalyan Thota (3): > drm/msm/disp/dpu1: clear dspp reservations in rm release > drm/msm/disp/dpu1: add dspps into reservation if there is a ctm > request > drm/msm/disp/dpu1: reserve the resources on topology change > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 1 + > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 54 +++++++++++++++++++++++------ > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 4 ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 6 ++-- > 5 files changed, 50 insertions(+), 17 deletions(-) >
On 2023-01-30 21:18:30, Dmitry Baryshkov wrote: > On 30/01/2023 17:21, Kalyan Thota wrote: > > This series will enable color features on sc7280 target which has primary panel as eDP > > > > The series removes dspp allocation based on encoder type and allows the dspp reservation > > based on user request via ctm. > > > > The series will release/reserve the dpu resources when ever there is a topology change > > to suit the new requirements. > > Nit: the subject of the cover letter should include the version, if you > are including one into the individual patches Subject. Indeed this makes it hard to tell the versions apart, and lore also confusingly bundles both series in "loose matches on Subject: below". Nit ^2: and individual patches should still have the PATCH moniker, i.e. [PATCH v2 1/3]. git format-patch -v2 --cover-letter ... takes care of /all this/ this for you. And one more: as DSPP is an abbreviation, can we capitalize it? So DSPP / DSPPs in these titles? > > > > Kalyan Thota (3): > > drm/msm/disp/dpu1: clear dspp reservations in rm release > > drm/msm/disp/dpu1: add dspps into reservation if there is a ctm > > request > > drm/msm/disp/dpu1: reserve the resources on topology change We just discussed in the DSC series that the subsystem prefix is drm/msm/dpu. - Marijn > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 1 + > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 54 +++++++++++++++++++++++------ > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 4 ++- > > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- > > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 6 ++-- > > 5 files changed, 50 insertions(+), 17 deletions(-) > > > > -- > With best wishes > Dmitry >
This series will enable color features on sc7280 target which has primary panel as eDP The series removes dspp allocation based on encoder type and allows the dspp reservation based on user request via ctm. The series will release/reserve the dpu resources when ever there is a topology change to suit the new requirements. Kalyan Thota (3): drm/msm/disp/dpu1: clear dspp reservations in rm release drm/msm/disp/dpu1: add dspps into reservation if there is a ctm request drm/msm/disp/dpu1: reserve the resources on topology change drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 54 +++++++++++++++++++++++------ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 4 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 6 ++-- 5 files changed, 50 insertions(+), 17 deletions(-)