From patchwork Wed Sep 19 15:56:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 10606053 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 65BE45A4 for ; Wed, 19 Sep 2018 15:57:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F60C2B120 for ; Wed, 19 Sep 2018 15:57:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 42FBB2B289; Wed, 19 Sep 2018 15:57:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D9C7F2B120 for ; Wed, 19 Sep 2018 15:57:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C67BD6E50D; Wed, 19 Sep 2018 15:57:06 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 979606E50D for ; Wed, 19 Sep 2018 15:57:05 +0000 (UTC) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 61E2C1C0C; Wed, 19 Sep 2018 17:57:03 +0200 (CEST) From: Kieran Bingham To: Laurent Pinchart , linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 0/2] drm: Alpha blending issue Date: Wed, 19 Sep 2018 16:56:57 +0100 Message-Id: <20180919155700.10342-1-kieran.bingham+renesas@ideasonboard.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandru-Cosmin Gheorghe , Kieran Bingham MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Testing on the RCar Salvaltor-XS using the rcar-du has identified that commit 161ad653d6c9 ("drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying the logic") caused a regression in display output on the primary planes. The effect was that primary plane was 'invisible' though secondary planes were displayed correctly. This issue turned out to be a change in the initialisation of the default alpha property value in the state object. A plane without an alpha property would leave the alpha property unset (and thus at zero, or 'transparent'). Two patches are thus presented, which both individually can fix this regression - but both are suitable for integration. The RCar-DU driver is updated to provide an alpha property on primary planes, as it isn't unreasonable to be able to set the property there. This alone would have the effect of ensuring that the default value was set to the full opaque setting, and repair the regression. As a separate patch, we also update __drm_atomic_helper_plane_reset() call such that the alpha values are always initialised to a more practical default value of DRM_BLEND_ALPHA_OPAQUE for all planes. Kieran Bingham (2): drm/atomic: Initialise planes with opaque alpha values drm: rcar-du: Enable alpha property on primary planes drivers/gpu/drm/drm_atomic_helper.c | 4 +--- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 7 ++++++- 2 files changed, 7 insertions(+), 4 deletions(-)