| Message ID | 20181218133749.h4bnf5n5ljsmr2kz@smtp.gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: KMS cleanup remove drm_mode_object dependency | expand |
On Tue, 18 Dec 2018, Shayenne Moura <shayenneluzmoura@gmail.com> wrote: > This patch serie removes drm_mode_object dependency from > drm_display_mode struct. This is part of KMS cleanup. For future reference: Please use git-send-email or fix the mail threading otherwise. Patches 1-7 should be in reply to the cover letter. Please justify the changes in the commit messages. Your current commit messages focus on *what* is being done, which is fairly obvious from the changes themselves. Please try to describe *why* this is being done. That's more important for posterity. (In this case, it's basically explained in the FIXME comment being removed in patch 7, as well as Documentation/gpu/todo.rst.) BR, Jani. > > Shayenne Moura (7): > drm: msm: Delete base.id prints > drm: Remove use of drm_mode_object > drm: omapdrm: Delete base.id prints > drm: i915: Delete base.id prints > drm: sti: Delete base.id prints > drm: meson: Delete base.id prints > drm: Complete remove drm_mode_object dependency > > drivers/gpu/drm/drm_crtc_helper.c | 5 ++--- > drivers/gpu/drm/drm_modes.c | 9 --------- > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 9 ++++----- > drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 ++-- > drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c | 4 ++-- > drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 ++-- > drivers/gpu/drm/msm/edp/edp_bridge.c | 4 ++-- > drivers/gpu/drm/omapdrm/omap_connector.c | 4 ++-- > drivers/gpu/drm/omapdrm/omap_crtc.c | 4 ++-- > drivers/gpu/drm/sti/sti_crtc.c | 4 ++-- > include/drm/drm_modes.h | 10 ++++------ > 17 files changed, 36 insertions(+), 49 deletions(-)
On 12/19, Jani Nikula wrote: > On Tue, 18 Dec 2018, Shayenne Moura <shayenneluzmoura@gmail.com> wrote: > > This patch serie removes drm_mode_object dependency from > > drm_display_mode struct. This is part of KMS cleanup. > > For future reference: > > Please use git-send-email or fix the mail threading otherwise. Patches > 1-7 should be in reply to the cover letter. > Sorry about that, > Please justify the changes in the commit messages. Your current commit > messages focus on *what* is being done, which is fairly obvious from the > changes themselves. Please try to describe *why* this is being > done. That's more important for posterity. (In this case, it's basically > explained in the FIXME comment being removed in patch 7, as well as > Documentation/gpu/todo.rst.) > > BR, > Jani. > Okay, thank you! But I should write on every patch why I am doing or just on the cover letter? Bests, Shayenne > > > > > Shayenne Moura (7): > > drm: msm: Delete base.id prints > > drm: Remove use of drm_mode_object > > drm: omapdrm: Delete base.id prints > > drm: i915: Delete base.id prints > > drm: sti: Delete base.id prints > > drm: meson: Delete base.id prints > > drm: Complete remove drm_mode_object dependency > > > > drivers/gpu/drm/drm_crtc_helper.c | 5 ++--- > > drivers/gpu/drm/drm_modes.c | 9 --------- > > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- > > drivers/gpu/drm/meson/meson_dw_hdmi.c | 9 ++++----- > > drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 4 ++-- > > drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c | 4 ++-- > > drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c | 4 ++-- > > drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 4 ++-- > > drivers/gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c | 4 ++-- > > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 ++-- > > drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c | 4 ++-- > > drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 ++-- > > drivers/gpu/drm/msm/edp/edp_bridge.c | 4 ++-- > > drivers/gpu/drm/omapdrm/omap_connector.c | 4 ++-- > > drivers/gpu/drm/omapdrm/omap_crtc.c | 4 ++-- > > drivers/gpu/drm/sti/sti_crtc.c | 4 ++-- > > include/drm/drm_modes.h | 10 ++++------ > > 17 files changed, 36 insertions(+), 49 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center
On Wed, 19 Dec 2018, Shayenne Moura <shayenneluzmoura@gmail.com> wrote: > On 12/19, Jani Nikula wrote: >> On Tue, 18 Dec 2018, Shayenne Moura <shayenneluzmoura@gmail.com> wrote: >> > This patch serie removes drm_mode_object dependency from >> > drm_display_mode struct. This is part of KMS cleanup. >> >> For future reference: >> >> Please use git-send-email or fix the mail threading otherwise. Patches >> 1-7 should be in reply to the cover letter. >> > Sorry about that, >> Please justify the changes in the commit messages. Your current commit >> messages focus on *what* is being done, which is fairly obvious from the >> changes themselves. Please try to describe *why* this is being >> done. That's more important for posterity. (In this case, it's basically >> explained in the FIXME comment being removed in patch 7, as well as >> Documentation/gpu/todo.rst.) >> >> BR, >> Jani. >> > Okay, thank you! But I should write on every patch why I am doing or > just on the cover letter? So this series is trivial enough that I can look the other way... ;) But in general each patch should have a justification, even if just one sentence in the commit message. The why. The commit messages get recorded in git history, but the cover letter gets lost. BR, Jani. > > Bests, > Shayenne >> >> > >> > Shayenne Moura (7): >> > drm: msm: Delete base.id prints >> > drm: Remove use of drm_mode_object >> > drm: omapdrm: Delete base.id prints >> > drm: i915: Delete base.id prints >> > drm: sti: Delete base.id prints >> > drm: meson: Delete base.id prints >> > drm: Complete remove drm_mode_object dependency >> > >> > drivers/gpu/drm/drm_crtc_helper.c | 5 ++--- >> > drivers/gpu/drm/drm_modes.c | 9 --------- >> > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- >> > drivers/gpu/drm/meson/meson_dw_hdmi.c | 9 ++++----- >> > drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp4/mdp4_dtv_encoder.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 ++-- >> > drivers/gpu/drm/msm/disp/mdp5/mdp5_encoder.c | 4 ++-- >> > drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 ++-- >> > drivers/gpu/drm/msm/edp/edp_bridge.c | 4 ++-- >> > drivers/gpu/drm/omapdrm/omap_connector.c | 4 ++-- >> > drivers/gpu/drm/omapdrm/omap_crtc.c | 4 ++-- >> > drivers/gpu/drm/sti/sti_crtc.c | 4 ++-- >> > include/drm/drm_modes.h | 10 ++++------ >> > 17 files changed, 36 insertions(+), 49 deletions(-) >> >> -- >> Jani Nikula, Intel Open Source Graphics Center