| Message ID | 20190103115954.12785-1-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/bridge: tc358767: small fixes | expand |
Hi Tomi, On 03.01.2019 12:59, Tomi Valkeinen wrote: > Hi, > > We have TC358867 on our board, which I believe is almost identical to > TC358767. We're using it with a DP connector instead of eDP with a fixed > panel. > > I have tested these patches only on TI's 4.14 based kernel, as > unfortunately we don't have all the necessary support in mainline yet. > These patches fix various bugs, but I'm still seeing at least two > issues: > > * Sync with some videomodes is not correct, resulting in a jumping and > skewed display > * Link training fails sometimes > > I would appreciate if someone is able to verify these patches with > TC358767. Do you want to wait for testers or shall I queue this patchset? Regards Andrzej > > Changes in v2: > - Addressed the comments > - Added reviewed bys > > Tomi > > Tomi Valkeinen (7): > drm/bridge: tc358767: add bus flags > drm/bridge: tc358767: add defines for DP1_SRCCTRL & PHY_2LANE > drm/bridge: tc358767: fix single lane configuration > drm/bridge: tc358767: fix initial DP0/1_SRCCTRL value > drm/bridge: tc358767: reject modes which require too much BW > drm/bridge: tc358767: fix output H/V syncs > drm/bridge: tc358767: use DP connector if no panel set > > drivers/gpu/drm/bridge/tc358767.c | 48 ++++++++++++++++++++++++------- > 1 file changed, 38 insertions(+), 10 deletions(-) >
Hi Andrzej, On 09/01/19 10:22, Andrzej Hajda wrote: > Hi Tomi, > > On 03.01.2019 12:59, Tomi Valkeinen wrote: >> Hi, >> >> We have TC358867 on our board, which I believe is almost identical to >> TC358767. We're using it with a DP connector instead of eDP with a fixed >> panel. >> >> I have tested these patches only on TI's 4.14 based kernel, as >> unfortunately we don't have all the necessary support in mainline yet. >> These patches fix various bugs, but I'm still seeing at least two >> issues: >> >> * Sync with some videomodes is not correct, resulting in a jumping and >> skewed display >> * Link training fails sometimes >> >> I would appreciate if someone is able to verify these patches with >> TC358767. > > > Do you want to wait for testers or shall I queue this patchset? I haven't heard from anyone, so I'm ok with pushing these. Tomi
Am Mittwoch, den 09.01.2019, 11:12 +0200 schrieb Tomi Valkeinen: > Hi Andrzej, > > On 09/01/19 10:22, Andrzej Hajda wrote: > > Hi Tomi, > > > > On 03.01.2019 12:59, Tomi Valkeinen wrote: > > > Hi, > > > > > > We have TC358867 on our board, which I believe is almost identical to > > > TC358767. We're using it with a DP connector instead of eDP with a fixed > > > panel. > > > > > > I have tested these patches only on TI's 4.14 based kernel, as > > > unfortunately we don't have all the necessary support in mainline yet. > > > These patches fix various bugs, but I'm still seeing at least two > > > issues: > > > > > > * Sync with some videomodes is not correct, resulting in a jumping and > > > skewed display > > > * Link training fails sometimes > > > > > > I would appreciate if someone is able to verify these patches with > > > TC358767. > > > > > > Do you want to wait for testers or shall I queue this patchset? > > I haven't heard from anyone, so I'm ok with pushing these. For the series: Tested-by: Lucas Stach <l.stach@pengutronix.de> on a device with TC358767 and a 4.20 based kernel. Regards, Lucas
On 09.01.2019 10:51, Lucas Stach wrote: > Am Mittwoch, den 09.01.2019, 11:12 +0200 schrieb Tomi Valkeinen: >> Hi Andrzej, >> >> On 09/01/19 10:22, Andrzej Hajda wrote: >>> Hi Tomi, >>> >>> On 03.01.2019 12:59, Tomi Valkeinen wrote: >>>> Hi, >>>> >>>> We have TC358867 on our board, which I believe is almost identical to >>>> TC358767. We're using it with a DP connector instead of eDP with a fixed >>>> panel. >>>> >>>> I have tested these patches only on TI's 4.14 based kernel, as >>>> unfortunately we don't have all the necessary support in mainline yet. >>>> These patches fix various bugs, but I'm still seeing at least two >>>> issues: >>>> >>>> * Sync with some videomodes is not correct, resulting in a jumping and >>>> skewed display >>>> * Link training fails sometimes >>>> >>>> I would appreciate if someone is able to verify these patches with >>>> TC358767. >>> >>> Do you want to wait for testers or shall I queue this patchset? >> I haven't heard from anyone, so I'm ok with pushing these. > For the series: > > Tested-by: Lucas Stach <l.stach@pengutronix.de> > > on a device with TC358767 and a 4.20 based kernel. Already queued :) Regards Andrzej > > Regards, > Lucas > > > >
On 09/01/19 11:51, Lucas Stach wrote: > For the series: > > Tested-by: Lucas Stach <l.stach@pengutronix.de> > > on a device with TC358767 and a 4.20 based kernel. Thanks Lucas. Does the device use TC358767 as eDP+panel, or as full DP with an external connector? We have the latter, and I think there are some missing pieces in the driver which I'll be working on some time in the near future. Tomi
Hi Tomi, Am Mittwoch, den 09.01.2019, 16:55 +0200 schrieb Tomi Valkeinen: > On 09/01/19 11:51, Lucas Stach wrote: > > > For the series: > > > > > > Tested-by: Lucas Stach <l.stach@pengutronix.de> > > > > on a device with TC358767 and a 4.20 based kernel. > > Thanks Lucas. > > Does the device use TC358767 as eDP+panel, or as full DP with an > external connector? We have the latter, and I think there are some > missing pieces in the driver which I'll be working on some time in the > near future. It's eDP + panel. Regards, Lucas
Hi Andrzej, On 09/01/19 12:12, Andrzej Hajda wrote: > On 09.01.2019 10:51, Lucas Stach wrote: >> Am Mittwoch, den 09.01.2019, 11:12 +0200 schrieb Tomi Valkeinen: >>> Hi Andrzej, >>> >>> On 09/01/19 10:22, Andrzej Hajda wrote: >>>> Hi Tomi, >>>> >>>> On 03.01.2019 12:59, Tomi Valkeinen wrote: >>>>> Hi, >>>>> >>>>> We have TC358867 on our board, which I believe is almost identical to >>>>> TC358767. We're using it with a DP connector instead of eDP with a fixed >>>>> panel. >>>>> >>>>> I have tested these patches only on TI's 4.14 based kernel, as >>>>> unfortunately we don't have all the necessary support in mainline yet. >>>>> These patches fix various bugs, but I'm still seeing at least two >>>>> issues: >>>>> >>>>> * Sync with some videomodes is not correct, resulting in a jumping and >>>>> skewed display >>>>> * Link training fails sometimes >>>>> >>>>> I would appreciate if someone is able to verify these patches with >>>>> TC358767. >>>> >>>> Do you want to wait for testers or shall I queue this patchset? >>> I haven't heard from anyone, so I'm ok with pushing these. >> For the series: >> >> Tested-by: Lucas Stach <l.stach@pengutronix.de> >> >> on a device with TC358767 and a 4.20 based kernel. > > > Already queued :) Did you push these somewhere? What's the route for these patches, drm-misc? Tomi
Hi Tomi, śr., 23 sty 2019, 13:52: Tomi Valkeinen <tomi.valkeinen@ti.com> napisał(a): > Hi Andrzej, > > On 09/01/19 12:12, Andrzej Hajda wrote: > > On 09.01.2019 10:51, Lucas Stach wrote: > >> Am Mittwoch, den 09.01.2019, 11:12 +0200 schrieb Tomi Valkeinen: > >>> Hi Andrzej, > >>> > >>> On 09/01/19 10:22, Andrzej Hajda wrote: > >>>> Hi Tomi, > >>>> > >>>> On 03.01.2019 12:59, Tomi Valkeinen wrote: > >>>>> Hi, > >>>>> > >>>>> We have TC358867 on our board, which I believe is almost identical to > >>>>> TC358767. We're using it with a DP connector instead of eDP with a > fixed > >>>>> panel. > >>>>> > >>>>> I have tested these patches only on TI's 4.14 based kernel, as > >>>>> unfortunately we don't have all the necessary support in mainline > yet. > >>>>> These patches fix various bugs, but I'm still seeing at least two > >>>>> issues: > >>>>> > >>>>> * Sync with some videomodes is not correct, resulting in a jumping > and > >>>>> skewed display > >>>>> * Link training fails sometimes > >>>>> > >>>>> I would appreciate if someone is able to verify these patches with > >>>>> TC358767. > >>>> > >>>> Do you want to wait for testers or shall I queue this patchset? > >>> I haven't heard from anyone, so I'm ok with pushing these. > >> For the series: > >> > >> Tested-by: Lucas Stach <l.stach@pengutronix.de> > >> > >> on a device with TC358767 and a 4.20 based kernel. > > > > > > Already queued :) > > Did you push these somewhere? What's the route for these patches, drm-misc? > drm-misc-fixes: https://github.com/freedesktop/drm-misc/commits/drm-misc-fixes/drivers/gpu/drm/bridge/tc358767.c Andrzej > Tomi > > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > <div dir="auto"><div>Hi Tomi,<br><br><div class="gmail_quote"><div dir="ltr">śr., 23 sty 2019, 13:52: Tomi Valkeinen <<a href="mailto:tomi.valkeinen@ti.com">tomi.valkeinen@ti.com</a>> napisał(a):<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Andrzej,<br> <br> On 09/01/19 12:12, Andrzej Hajda wrote:<br> > On 09.01.2019 10:51, Lucas Stach wrote:<br> >> Am Mittwoch, den 09.01.2019, 11:12 +0200 schrieb Tomi Valkeinen:<br> >>> Hi Andrzej,<br> >>><br> >>> On 09/01/19 10:22, Andrzej Hajda wrote:<br> >>>> Hi Tomi,<br> >>>><br> >>>> On 03.01.2019 12:59, Tomi Valkeinen wrote:<br> >>>>> Hi,<br> >>>>><br> >>>>> We have TC358867 on our board, which I believe is almost identical to<br> >>>>> TC358767. We're using it with a DP connector instead of eDP with a fixed<br> >>>>> panel.<br> >>>>><br> >>>>> I have tested these patches only on TI's 4.14 based kernel, as<br> >>>>> unfortunately we don't have all the necessary support in mainline yet.<br> >>>>> These patches fix various bugs, but I'm still seeing at least two<br> >>>>> issues:<br> >>>>><br> >>>>> * Sync with some videomodes is not correct, resulting in a jumping and<br> >>>>> skewed display<br> >>>>> * Link training fails sometimes<br> >>>>><br> >>>>> I would appreciate if someone is able to verify these patches with<br> >>>>> TC358767.<br> >>>><br> >>>> Do you want to wait for testers or shall I queue this patchset?<br> >>> I haven't heard from anyone, so I'm ok with pushing these.<br> >> For the series:<br> >><br> >> Tested-by: Lucas Stach <<a href="mailto:l.stach@pengutronix.de" target="_blank" rel="noreferrer">l.stach@pengutronix.de</a>><br> >><br> >> on a device with TC358767 and a 4.20 based kernel.<br> > <br> > <br> > Already queued :)<br> <br> Did you push these somewhere? What's the route for these patches, drm-misc?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">drm-misc-fixes:</div><div dir="auto"><br></div><div dir="auto"><a href="https://github.com/freedesktop/drm-misc/commits/drm-misc-fixes/drivers/gpu/drm/bridge/tc358767.c">https://github.com/freedesktop/drm-misc/commits/drm-misc-fixes/drivers/gpu/drm/bridge/tc358767.c</a><br></div><div dir="auto"><br></div><div dir="auto">Andrzej</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br> Tomi<br> <br> -- <br> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.<br> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki<br> _______________________________________________<br> dri-devel mailing list<br> <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank" rel="noreferrer">dri-devel@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br> </blockquote></div></div></div>