From patchwork Thu Jan 10 15:10:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 10757489 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6ECE8159A for ; Fri, 11 Jan 2019 08:18:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55FA22995E for ; Fri, 11 Jan 2019 08:18:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4A02929965; Fri, 11 Jan 2019 08:18:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 87D6C2995E for ; Fri, 11 Jan 2019 08:18:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FDA46E6EC; Fri, 11 Jan 2019 08:18:05 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80132.outbound.protection.outlook.com [40.107.8.132]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A6166F366 for ; Thu, 10 Jan 2019 15:10:31 +0000 (UTC) Received: from AM6PR02MB4470.eurprd02.prod.outlook.com (20.177.191.218) by AM6PR02MB4037.eurprd02.prod.outlook.com (20.177.112.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.14; Thu, 10 Jan 2019 15:10:28 +0000 Received: from AM6PR02MB4470.eurprd02.prod.outlook.com ([fe80::e5f3:a239:2ec4:4453]) by AM6PR02MB4470.eurprd02.prod.outlook.com ([fe80::e5f3:a239:2ec4:4453%6]) with mapi id 15.20.1516.015; Thu, 10 Jan 2019 15:10:28 +0000 From: Peter Rosin To: "linux-kernel@vger.kernel.org" Subject: [PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues Thread-Topic: [PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues Thread-Index: AQHUqPaeuHFV8522kE2kP/gCblgMKA== Date: Thu, 10 Jan 2019 15:10:28 +0000 Message-ID: <20190110151020.30468-1-peda@axentia.se> Accept-Language: en-US, sv-SE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.11.0 x-originating-ip: [85.226.244.23] x-clientproxiedby: HE1PR05CA0257.eurprd05.prod.outlook.com (2603:10a6:3:fb::33) To AM6PR02MB4470.eurprd02.prod.outlook.com (2603:10a6:20b:60::26) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR02MB4037; 6:G8Kcj0vO2NTx1WVVLDqFWwRoBQXMEqoaL7wAnVUeWi0CH6Qcla53HJWo1mYAmmgpWc70q4hPird5QJnFwxIcUAJi+j93DhB4wTeqql0HI1fGMmogKJ8pEOZFUZMhn1jhtPaCve00hTS5Dtlrkm3vfGEXAmg/RpmVRnzRbBhryDScPjS3KFR3+KqKeohRr3zZHcarlN5hAuakx/O+ABxAxtr2ckBIRLtr5Lknijq95xlhjYI8GMD7ZoMG6dNyTOLgad0pVkj4QXdmZHrQ7kh1d86u8wmvBzvReWGsaGl7H9ZvHkF33hF3ZlSVKQEnJL1Y93OQGDe53/badJ/NNE5WafQxPOgzZ5/H09P2p9lUfXvuMVyWaLMbfuuBn4sm3Bs/cQsH8P92VzgLE2buMFmXkEF07FTnd2Vvxusu2OXxTcZxYg9V8IeGuXQ6RZcQimx2noxCT+f5cvRNHptnvNvDrw==; 5:Ysd7c8cDMdS+R3kCG3Dez2JyXOi6c4mGagird/155OX6HtcPHHPShVUrsBQ4VRWUkKh28qImdAhsaG/2N+jFtY8OATy3A4xjgtWnv6AuN89gMgN1l7nT+v1lsvfYeVu3uM15QUb3kvTENJJ+sMv/4t0D5FjGarpUS2fsppmP13X5irEcogVGgK51t3l6ONlG8FUpivWHElRw3vbVFg8Mng==; 7:iFdt/lvb1fsMxvpRPx7D6+rZHztsiEHomofHHl1NCxIx/qwD3NG3kyAZ13igzQR1VjDAxJ+hnGd+hNlQBBm0xmgFqq4yhcKDAdLBPI/zb+OcRj86GFkch9S33AesXODxjmdswX/NW7jB2NWcSfADRA== x-ms-office365-filtering-correlation-id: 8408dcce-613a-4e1e-06d5-08d6770dc101 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(5600109)(711020)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(2017052603328)(7153060)(7193020); SRVR:AM6PR02MB4037; x-ms-traffictypediagnostic: AM6PR02MB4037: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(3231475)(944501520)(52105112)(93006095)(93001095)(10201501046)(3002001)(6041310)(20161123558120)(2016111802025)(20161123562045)(20161123560045)(20161123564045)(6043046)(201708071742011)(7699051)(76991095); SRVR:AM6PR02MB4037; BCL:0; PCL:0; RULEID:; SRVR:AM6PR02MB4037; x-forefront-prvs: 0913EA1D60 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39830400003)(136003)(366004)(396003)(346002)(376002)(199004)(189003)(53936002)(316002)(36756003)(6512007)(97736004)(50226002)(5660300001)(66066001)(186003)(386003)(4326008)(6506007)(25786009)(26005)(256004)(2501003)(476003)(102836004)(2616005)(6916009)(14454004)(71190400001)(71200400001)(106356001)(105586002)(2906002)(68736007)(7736002)(486006)(5640700003)(1076003)(6436002)(6486002)(508600001)(2351001)(81156014)(99286004)(81166006)(3846002)(8936002)(305945005)(6116002)(8676002)(86362001)(54906003)(74482002)(52116002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM6PR02MB4037; H:AM6PR02MB4470.eurprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: axentia.se does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: JhG07iMEH4OYnjoxlh2bhoUK2psTqxSmqyyEj6VTn5VsKM/I9bmCb6CD3kkM45kjpTJuo3lm6bjpJAX7nSwChpTDOU/+4X7d+rWvXlYH5WJ0DMNLHCzlPQQQkTlzD0bv3qMGRmr/CuyTiKo1pOdSXywGLF2/tkL5AWJsWcL6AeKf1RtW80LPfoeTjGL861ib3L79G3xLl1abQ4dlVz/v3VX3+DD5kUM3DprhQCec+NiDL2fVF7aLqEFA0PQb8u6esnV3om82/0g4cQ+qXy08Cm+b8UmXMINXpPchtVkoxnBkskLgdg2vzSyjnVzRMng2 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: 8408dcce-613a-4e1e-06d5-08d6770dc101 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2019 15:10:27.0800 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR02MB4037 X-Mailman-Approved-At: Fri, 11 Jan 2019 08:18:04 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , David Airlie , Nicolas Ferre , "dri-devel@lists.freedesktop.org" , Boris Brezillon , Peter Rosin , "linux-arm-kernel@lists.infradead.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi! I found an unfortunate issue while recoding plane handling to use drm_atomic_helper_check_plane_state(). The driver rotates clockwise, which is not correct. I simply fixed it (patch 1/4), but maybe that will cause regressions for unsuspecting users who simply assumed that the clockwise rotation was correct? I don't know what to do about that? Adding an option to get the old broken behavior seems useless, wouldn't it be just as easy to just fix whatever app to rotate the other way instead of adding an option somewhere? I have only tested this series on sama5d3, but I did check the docs for various other chips (sama5d2, sama5d4, sam9n12, sam9g15, sam9g35 and sam9x35) supported by the driver (relevant to patch 4/4). Cheers, Peter Peter Rosin (4): drm/atmel-hlcdc: rotate planes counterclockwise drm/atmel-hlcdc: do not swap w/h of the crtc when a plane is rotated drm/atmel-hlcdc: fix clipping of planes drm/atmel-hlcdc: do not immediately disable planes, wait for next frame drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 179 +++++++++--------------- 1 file changed, 67 insertions(+), 112 deletions(-)