| Message ID | 20190125110211.5877-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Replace ttm_bo_{unref, reference} with ttm_bo_{get|put} | expand |
Reviewed-by: Christian König <christian.koenig@amd.com> If there are no objections over the weekend I'm going to push that into upstream direction on monday. Thanks for the work, Christian. Am 25.01.19 um 12:02 schrieb Thomas Zimmermann: > This patchset cleans up the last remaining callers of ttm_bo_reference > and ttm_bo_unref. Calls are replaced with ttm_bo_get and ttm_bo_put, > which follow Linux' get/put semantics more closely. > > The most notable difference is that ttm_bo_get does not clear the supplied > pointer's value. This behaviour is now located in the calling code for cases > where it might be required. > > v2: > * rebased onto drm-tip > > Thomas Zimmermann (7): > drm/ast: Replace ttm_bo_unref with ttm_bo_put > drm/nouveau: Replace ttm_bo_reference with ttm_bo_get > drm/nouveau: Replace ttm_bo_unref with ttm_bo_put > drm/vmwgfx: Replace ttm_bo_reference with ttm_bo_get > drm/vmwgfx: Replace ttm_bo_unref with ttm_bo_put > drm/mgag200: Replace ttm_bo_unref with ttm_bo_put > drm/ttm: Remove ttm_bo_reference and ttm_bo_unref > > drivers/gpu/drm/ast/ast_main.c | 6 +---- > drivers/gpu/drm/mgag200/mgag200_main.c | 8 ++----- > drivers/gpu/drm/nouveau/nouveau_bo.h | 12 ++++++---- > drivers/gpu/drm/nouveau/nouveau_gem.c | 3 +-- > drivers/gpu/drm/ttm/ttm_bo.c | 9 ------- > drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 11 ++++----- > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 11 +++++---- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 9 +++---- > drivers/gpu/drm/vmwgfx/vmwgfx_mob.c | 21 ++++++++++------ > drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 9 ++++--- > drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 6 +++-- > include/drm/ttm/ttm_bo_api.h | 28 ---------------------- > 12 files changed, 49 insertions(+), 84 deletions(-) >
Also looks for me. Thanks Thomas. Reviewed-by: Huang Rui <ray.huang@amd.com> > -----Original Message----- > From: Koenig, Christian > Sent: Friday, January 25, 2019 7:29 PM > To: Thomas Zimmermann <tzimmermann@suse.de>; Huang, Ray > <Ray.Huang@amd.com>; Zhang, Jerry <Jerry.Zhang@amd.com>; > airlied@redhat.com; bskeggs@redhat.com; linux-graphics- > maintainer@vmware.com; thellstrom@vmware.com; dri- > devel@lists.freedesktop.org > Subject: Re: [PATCH v2 0/7] Replace ttm_bo_{unref,reference} with > ttm_bo_{get|put} > > Reviewed-by: Christian König <christian.koenig@amd.com> > > If there are no objections over the weekend I'm going to push that into > upstream direction on monday. > > Thanks for the work, > Christian. > > Am 25.01.19 um 12:02 schrieb Thomas Zimmermann: > > This patchset cleans up the last remaining callers of ttm_bo_reference > > and ttm_bo_unref. Calls are replaced with ttm_bo_get and ttm_bo_put, > > which follow Linux' get/put semantics more closely. > > > > The most notable difference is that ttm_bo_get does not clear the > > supplied pointer's value. This behaviour is now located in the calling > > code for cases where it might be required. > > > > v2: > > * rebased onto drm-tip > > > > Thomas Zimmermann (7): > > drm/ast: Replace ttm_bo_unref with ttm_bo_put > > drm/nouveau: Replace ttm_bo_reference with ttm_bo_get > > drm/nouveau: Replace ttm_bo_unref with ttm_bo_put > > drm/vmwgfx: Replace ttm_bo_reference with ttm_bo_get > > drm/vmwgfx: Replace ttm_bo_unref with ttm_bo_put > > drm/mgag200: Replace ttm_bo_unref with ttm_bo_put > > drm/ttm: Remove ttm_bo_reference and ttm_bo_unref > > > > drivers/gpu/drm/ast/ast_main.c | 6 +---- > > drivers/gpu/drm/mgag200/mgag200_main.c | 8 ++----- > > drivers/gpu/drm/nouveau/nouveau_bo.h | 12 ++++++---- > > drivers/gpu/drm/nouveau/nouveau_gem.c | 3 +-- > > drivers/gpu/drm/ttm/ttm_bo.c | 9 ------- > > drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 11 ++++----- > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 11 +++++---- > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 9 +++---- > > drivers/gpu/drm/vmwgfx/vmwgfx_mob.c | 21 ++++++++++------ > > drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 9 ++++--- > > drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 6 +++-- > > include/drm/ttm/ttm_bo_api.h | 28 ---------------------- > > 12 files changed, 49 insertions(+), 84 deletions(-) > >