From patchwork Fri Mar 22 05:17:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yifeng Li X-Patchwork-Id: 10867733 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F35621390 for ; Sun, 24 Mar 2019 21:06:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E159829272 for ; Sun, 24 Mar 2019 21:06:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D5AA929275; Sun, 24 Mar 2019 21:06:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A5C7729272 for ; Sun, 24 Mar 2019 21:06:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DBD06E604; Sun, 24 Mar 2019 21:06:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from tomli.me (tomli.me [IPv6:2a00:1a28:1157:199::5a76]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0AE5289319 for ; Fri, 22 Mar 2019 05:18:15 +0000 (UTC) Received: from tomli.me (localhost [127.0.0.1]) by tomli.me (OpenSMTPD) with ESMTP id 6f39e4af; Fri, 22 Mar 2019 05:18:13 +0000 (UTC) X-HELO: localhost.lan Received: from Unknown (HELO localhost.lan) (2402:f000:1:1501:200:5efe:dddb:8cda) by tomli.me (qpsmtpd/0.95) with ESMTPSA (DHE-RSA-CHACHA20-POLY1305 encrypted); Fri, 22 Mar 2019 05:18:13 +0000 From: Yifeng Li To: Sudip Mukherjee , Teddy Wang , linux-kernel@vger.kernel.org Subject: [PATCH v2 0/7] implement 2D acceleration, minor cleanups, doc updates. Date: Fri, 22 Mar 2019 13:17:52 +0800 Message-Id: <20190322051759.15007-1-tomli@tomli.me> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 24 Mar 2019 21:01:57 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tomli.me; h=from:to:cc:subject:date:message-id:mime-version:content-transfer-encoding; s=1490979754; bh=iT1goqnBjPuuRsgh3AB8p5c6w7N3iXAQ/0EHVvO0q+c=; b=zvHCcE4IkUcqdCvvvWlEo9lwdWaD9g8OBo+8BVlVGwUUQY2JifXU+NgPcrPFoY485IWA5PgdQnWDObbwfNrCfg/6d6EGCkk2GlJIHunIPDMq6oXovAQ808pl+vOLBv4M8h0+PATIP9H726v+inM419NTyA43Uzggl5jk2jXTifq/KEDsuMcVMbdZeMNuZ1VajyNaxh3p3p8P3eGbCRIfm1vzpwcWYcziMzakBR0Yee6p2qapXHAScnFd93O0jy/hbsSpL2r7hbIoq9LhYlAS58d30X+/Gfq/7zU9igg7T+lsbeUCBzOoBmM0u9LChm7+VNdE2hfgtjqieNSqajimEQ== X-Mailman-Original-Authentication-Results: tomli.me; auth=pass (login) smtp.auth=tomli X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Yifeng Li , dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP v2: - Also implement 2D acceleration for SM720. - Remove writel_relaxed() and an explicit memory barrier, on MIPS, PowerPC and x86, relaxed writes do not have additional performance, and complicates the code. - Document additional issues in the driver. NOTE: - This patchset should be applied after "[PATCH 0/8] fbdev: sm712fb: fix a series of lockups, crashes and gliches" (*), as it contains important fixes for issues in the original driver. - This patchset has been tested by the author for SM712 and SM720, on MIPS and x86 without problem. (*) https://marc.info/?l=linux-fbdev&m=155277512210375&w=2 Previously, in staging/sm7xxfb (now fbdev/sm712fb), 2D acceleration was implemented, but after its submission, a critical bug that causes total system hang was discovered, as a stopgap measure, 2D ops was completele removed in commit 3af805735a25 ("staging: sm7xx: remove the buggy 2D acceleration support") and never implemented again. It created a massive usability problem - on YeeLoong 8089, a notable MIPS platform which uses SM712 - even scrolling a single line of text on the console required an unaccelerated screen redraw, running "dmesg" typically takes 8-11 seconds, and absurdly, printf(), became a significant performance bottleneck that slows down GCC and "make", make the computer largely unusable. So I decided to take a look. Most of the my actual development was done in 2014 in a personal out-of-tree driver, I did not mainline it because 2D acceleration was not working properly in 24-bit color. I discovered the solution in early 2019 and now it's ready to be mainlined. This commit reimplements the 2D acceleration for sm712fb. Unlike the original implementation, which was messy and unnecessarily complicated by calling a 2D acceleration wrapper file with many unneeded functions, this is a minimum and (relatively) clean implementation. My tests have shown that running "dmesg" only takes 0.9 seconds, a performance boost of 950%. System hangs did not occur in my tests. Currently, 2D acceleration is only supported on little-endian CPUs, it's disabled on Big Endian systems as a safety measure, since I code for myself without any monetary or hardware support from any company or OEMs, I don't have the hardware and it's completely untested. I should be also to purchase a Big Endian test platform and add proper support soon. Also, thanks to Miodrag Vallat and other OpenBSD developers, this work would be impossible without their code, that served as a reference implementation for me. Finally, during the development and testing of 2D acceleration, many identified existing issues in driver in general have been documented. Yifeng Li (7): fbdev: sm712fb: use type "u8" for 8-bit I/O. fbdev: sm712fb: add 2D-related I/O headers and functions. fbdev: sm712fb: support 2D acceleration on SM712 w/ Little-Endian CPU. fbdev: sm712fb: add 32-bit color modes, drops some other modes. Documentation: fb: sm712fb: add information mainly about 2D. fbdev: sm712fb: Kconfig: add information about docs. MAINTAINERS: sm712fb: list myself as one maintainer. Documentation/fb/sm712fb.txt | 129 +++++++- MAINTAINERS | 1 + drivers/video/fbdev/Kconfig | 4 + drivers/video/fbdev/sm712.h | 109 ++++++- drivers/video/fbdev/sm712fb.c | 551 +++++++++++++++++++++++++--------- 5 files changed, 642 insertions(+), 152 deletions(-)