From patchwork Tue Mar 26 10:31:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 10870825 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EE7E9922 for ; Tue, 26 Mar 2019 10:32:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D9D2028EE2 for ; Tue, 26 Mar 2019 10:32:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CD72928FE2; Tue, 26 Mar 2019 10:32:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 59F8128EE2 for ; Tue, 26 Mar 2019 10:32:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B3AD6E7DE; Tue, 26 Mar 2019 10:32:32 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by gabe.freedesktop.org (Postfix) with ESMTPS id A7BF86E7DE for ; Tue, 26 Mar 2019 10:32:31 +0000 (UTC) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x2QAWQ0m086399; Tue, 26 Mar 2019 05:32:26 -0500 Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x2QAWQPO002538 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 26 Mar 2019 05:32:26 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 26 Mar 2019 05:32:26 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 26 Mar 2019 05:32:26 -0500 Received: from deskari.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x2QAWN22071249; Tue, 26 Mar 2019 05:32:23 -0500 From: Tomi Valkeinen To: Andrzej Hajda , Laurent Pinchart , , Lucas Stach , Andrey Gusakov , Philipp Zabel , Andrey Smirnov , Jyri Sarha , Peter Ujfalusi , Benoit Parrot Subject: [PATCHv2 00/22] drm/bridge: tc358767: DP support Date: Tue, 26 Mar 2019 12:31:24 +0200 Message-ID: <20190326103146.24795-1-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1553596346; bh=FlMBo7zIFxOC038dP0N13X/8Rw5EkKzZ/G6mL1+fbHI=; h=From:To:CC:Subject:Date; b=Dq17zKDgzBP8ijG8BmJvHKpEvAVyLHy8WtOC6+nW26q2FF2QlnN4NRbL6S4tMKcg7 h3ND2ca3qr+79rJpR8idbkycbl2VSAaJZL47XSDj8Zw1NTRusd22RZ6HF/FxiBxblK uibpOJds4fCXOUPAN2uhvaJlbFahH8RMlZpBsZJ0= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi, tc358767 bridge was originally implemented for eDP use with an embedded panel. I've been working to add DP and HPD support, and this series is the result. I did have a lot of issues with link training, but with these, it's been working reliably with my devices. Compared to v1, I dropped the "implement naive HPD handling". I managed to modify my board to support interrupts, and in this series also interrupt based HPD is supported with the last two patches. The other patches should be unchanged to the v1. While I think the HPD support works ok, I'm unsure about the DT binding. I first tried implementing the HPD as a gpiochip, but for interrupts I then needed irqchip, and the amount of code started to increase a lot, whereas in my current patch the code is quite simple and short. So, here I have a simple 'hpd-num' DT property to mark which (if any) of the two GPIO pins is used for HPD. I have tested this with interrupt and polling based HPD, and also with a "simulated" eDP panel (DP monitor but defining a simple-panel in the DT data). Tomi Tomi Valkeinen (22): drm/bridge: tc358767: fix tc_aux_get_status error handling drm/bridge: tc358767: reset voltage-swing & pre-emphasis drm/bridge: tc358767: fix ansi 8b10b use drm/bridge: tc358767: cleanup spread & scrambler_dis drm/bridge: tc358767: remove unused swing & preemp drm/bridge: tc358767: cleanup aux_link_setup drm/bridge: tc358767: move video stream setup to tc_main_link_stream drm/bridge: tc358767: split stream enable/disable drm/bridge: tc358767: move PXL PLL enable/disable to stream enable/disable drm/bridge: tc358767: add link disable function drm/bridge: tc358767: ensure DP is disabled before LT drm/bridge: tc358767: remove unnecessary msleep drm/bridge: tc358767: use more reliable seq when finishing LT drm/bridge: tc358767: cleanup LT result check drm/bridge: tc358767: clean-up link training drm/bridge: tc358767: remove check for video mode in link enable drm/bridge: tc358767: use bridge mode_valid drm/bridge: tc358767: remove tc_connector_best_encoder drm/bridge: tc358767: copy the mode data, instead of storing the pointer drm/bridge: tc358767: add GPIO & interrupt registers drm/bridge: tc358767: add IRQ and HPD support dt-bindings: tc358767: add IRQ & HPD support .../display/bridge/toshiba,tc358767.txt | 3 + drivers/gpu/drm/bridge/tc358767.c | 558 +++++++++++------- 2 files changed, 353 insertions(+), 208 deletions(-)