[0/9] R-Car DU: Add missing RGB pixel formats

Message

Laurent Pinchart March 28, 2019, 7:07 a.m. UTC

Hello,

This patch series adds support for 16 missing RGB formats to the DU
driver. To do is, the formats are first added to the VSP1 driver.
Patches 1/9 to 3/9 define those formats in the V4L2 API, patches 4/9 to
6/9 add them to the VSP driver, and patches 7/9 to 9/9 finally add them
to the DU driver.

There's nothing very special here, but those patches are likely very
error-prone due to the many instances of very similar constructs. I
would thus appreciate careful review.

The new V4L2 4CCs match (or at least should match if I haven't made any
mistake) the DRM 4CCs, but the names of the format macros differ in
order to stick to the V4L2 naming scheme.

Laurent Pinchart (9):
  v4l: Add definitions for missing 32-bit RGB formats
  v4l: Add definitions for missing 16-bit RGB4444 formats
  v4l: Add definitions for missing 16-bit RGB555 formats
  media: vsp1: Add support for missing 32-bit RGB formats
  media: vsp1: Add support for missing 16-bit RGB444 formats
  media: vsp1: Add support for missing 16-bit RGB555 formats
  drm: rcar-du: Add support for missing 32-bit RGB formats
  drm: rcar-du: Add support for missing 16-bit RGB4444 formats
  drm: rcar-du: Add support for missing 16-bit RGB1555 formats

 .../media/uapi/v4l/pixfmt-packed-rgb.rst      | 436 ++++++++++++++++++
 drivers/gpu/drm/rcar-du/rcar_du_kms.c         |  80 ++++
 drivers/media/platform/vsp1/vsp1_pipe.c       |  70 +++
 include/uapi/linux/videodev2.h                |  16 +
 4 files changed, 602 insertions(+)

Comments

Laurent Pinchart April 20, 2019, 1:09 p.m. UTC | #1

Hi Dave,

On Thu, Mar 28, 2019 at 09:07:14AM +0200, Laurent Pinchart wrote:
> Hello,
> 
> This patch series adds support for 16 missing RGB formats to the DU
> driver. To do is, the formats are first added to the VSP1 driver.
> Patches 1/9 to 3/9 define those formats in the V4L2 API, patches 4/9 to
> 6/9 add them to the VSP driver, and patches 7/9 to 9/9 finally add them
> to the DU driver.

This series touches both V4L2 and DRM drivers. I think it would be
easier to merge it through the V4L2 tree, as the changes on the DRM side
as minimal (see patches 7/9 to 9/9). Would that be OK with you ? I will
of course make sure to avoid conflict with the R-Car DU patches already
merged in your tree.

> There's nothing very special here, but those patches are likely very
> error-prone due to the many instances of very similar constructs. I
> would thus appreciate careful review.
> 
> The new V4L2 4CCs match (or at least should match if I haven't made any
> mistake) the DRM 4CCs, but the names of the format macros differ in
> order to stick to the V4L2 naming scheme.
> 
> Laurent Pinchart (9):
>   v4l: Add definitions for missing 32-bit RGB formats
>   v4l: Add definitions for missing 16-bit RGB4444 formats
>   v4l: Add definitions for missing 16-bit RGB555 formats
>   media: vsp1: Add support for missing 32-bit RGB formats
>   media: vsp1: Add support for missing 16-bit RGB444 formats
>   media: vsp1: Add support for missing 16-bit RGB555 formats
>   drm: rcar-du: Add support for missing 32-bit RGB formats
>   drm: rcar-du: Add support for missing 16-bit RGB4444 formats
>   drm: rcar-du: Add support for missing 16-bit RGB1555 formats
> 
>  .../media/uapi/v4l/pixfmt-packed-rgb.rst      | 436 ++++++++++++++++++
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c         |  80 ++++
>  drivers/media/platform/vsp1/vsp1_pipe.c       |  70 +++
>  include/uapi/linux/videodev2.h                |  16 +
>  4 files changed, 602 insertions(+)