[v6,0/8] drm/fb-helper: Move modesetting code to drm_client

Message

Noralf Trønnes May 23, 2019, 1:44 p.m. UTC

This moves the modesetting code from drm_fb_helper to drm_client so it
can be shared by all internal clients.

Changes this time:
- Improve commit messages

All patches have been reviewed now, thanks alot for reviewing!

Noralf.

Noralf Trønnes (8):
  drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()
  drm/fb-helper: Remove drm_fb_helper_crtc
  drm/fb-helper: Prepare to move out commit code
  drm/fb-helper: Move out commit code
  drm/fb-helper: Remove drm_fb_helper_connector
  drm/fb-helper: Prepare to move out modeset config code
  drm/fb-helper: Move out modeset config code
  drm/client: Hack: Add bootsplash example

 Documentation/gpu/drm-client.rst     |    3 +
 Documentation/gpu/todo.rst           |    7 +
 drivers/gpu/drm/Kconfig              |    5 +
 drivers/gpu/drm/Makefile             |    3 +-
 drivers/gpu/drm/drm_atomic.c         |  168 ++++
 drivers/gpu/drm/drm_atomic_helper.c  |  164 ----
 drivers/gpu/drm/drm_bootsplash.c     |  358 +++++++
 drivers/gpu/drm/drm_client.c         |   17 +-
 drivers/gpu/drm/drm_client_modeset.c | 1086 +++++++++++++++++++++
 drivers/gpu/drm/drm_crtc_internal.h  |    5 +
 drivers/gpu/drm/drm_drv.c            |    4 +
 drivers/gpu/drm/drm_fb_helper.c      | 1305 ++------------------------
 include/drm/drm_atomic_helper.h      |    4 -
 include/drm/drm_client.h             |   49 +
 include/drm/drm_fb_helper.h          |   92 +-
 15 files changed, 1800 insertions(+), 1470 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_bootsplash.c
 create mode 100644 drivers/gpu/drm/drm_client_modeset.c

Comments

Sam Ravnborg May 23, 2019, 4:53 p.m. UTC | #1

Hi Linus, Gerd.

> This moves the modesetting code from drm_fb_helper to drm_client so it
> can be shared by all internal clients.

Could one of you take a look at this series.
Daniel already ack'ed the series on irc, but an extra pair of eyes
is never bad.

For my part I have been through them all, but I still do not have
the full picture of the DRM subsystem so my review may not
suffice.

	Sam

Gerd Hoffmann May 24, 2019, 12:10 p.m. UTC | #2

On Thu, May 23, 2019 at 06:53:20PM +0200, Sam Ravnborg wrote:
> Hi Linus, Gerd.
> 
> > This moves the modesetting code from drm_fb_helper to drm_client so it
> > can be shared by all internal clients.
> 
> Could one of you take a look at this series.
> Daniel already ack'ed the series on irc, but an extra pair of eyes
> is never bad.
> 
> For my part I have been through them all, but I still do not have
> the full picture of the DRM subsystem so my review may not
> suffice.

Looks sane to me overall.  Tried to give the series a spin in qemu, but:

ERROR: "drm_client_panel_rotation" [drivers/gpu/drm/drm_kms_helper.ko]
undefined!

EXPORT_SYMBOL() missing?

cheers,
  Gerd

Linus Walleij May 24, 2019, 3:18 p.m. UTC | #3

On Thu, May 23, 2019 at 6:53 PM Sam Ravnborg <[e-mail]> wrote:

> Could one of you take a look at this series.
> Daniel already ack'ed the series on irc, but an extra pair of eyes
> is never bad.

I would if I had a chance of understanding them. I am still pretty
novice with DRM so what I do is trace down to the calls I
need and understand the small pieces I use.

Yours,
Linus Walleij

Sam Ravnborg May 24, 2019, 3:26 p.m. UTC | #4

Hi Linus.

Thanks for the response.

> > Could one of you take a look at this series.
> > Daniel already ack'ed the series on irc, but an extra pair of eyes
> > is never bad.
> 
> I would if I had a chance of understanding them. I am still pretty
> novice with DRM so what I do is trace down to the calls I
> need and understand the small pieces I use.

We are almost on the same page here, expect that I am sometimes
at loss understanding :-)

	Sam