Message ID | 20190613142943.vhgiy6yvyjz6uqlp@shell.armlinux.org.uk (mailing list archive) |
---|---|
Headers | show |
Series | tda998x updates | expand |
Nit: checkpatch.pl appears unhappy with this patch: WARNING: line over 80 characters #222: FILE: drivers/gpu/drm/i2c/tda998x_drv.c:1011: + audio.params.config = priv->audio_port[i].config; WARNING: line over 80 characters #230: FILE: drivers/gpu/drm/i2c/tda998x_drv.c:1017: + audio.params.config = priv->audio_port[i].config; total: 0 errors, 2 warnings, 178 lines checked
On Thu, Jun 13, 2019 at 10:29 AM Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote: > > This series represents development work collected over the last six > months to improve the TDA998x driver, particularly for the audio > side. These patches can be found in my "drm-tda998x-devel" branch > at git://git.armlinux.org.uk/~rmk/linux-arm.git For the whole patchset, after 'hacking' the bclk_ratio to correspond with my imx6q ssi's wire format: Tested-by: Sven Van Asbroeck <TheSven73@gmail.com>
On Thu, Jun 13, 2019 at 02:48:47PM -0400, Sven Van Asbroeck wrote: > Nit: checkpatch.pl appears unhappy with this patch: > > WARNING: line over 80 characters > #222: FILE: drivers/gpu/drm/i2c/tda998x_drv.c:1011: > + audio.params.config = priv->audio_port[i].config; > > WARNING: line over 80 characters > #230: FILE: drivers/gpu/drm/i2c/tda998x_drv.c:1017: > + audio.params.config = priv->audio_port[i].config; > > total: 0 errors, 2 warnings, 178 lines checked Considering that code is going away in the very next patch, those warnings are not something I'm concerned about - the extra hassle of formatting the code so checkpatch is happy only to remove it in the next patch is not worth the effort.
On Thu, Jun 13, 2019 at 03:51:06PM -0400, Sven Van Asbroeck wrote: > On Thu, Jun 13, 2019 at 10:29 AM Russell King - ARM Linux admin > <linux@armlinux.org.uk> wrote: > > > > This series represents development work collected over the last six > > months to improve the TDA998x driver, particularly for the audio > > side. These patches can be found in my "drm-tda998x-devel" branch > > at git://git.armlinux.org.uk/~rmk/linux-arm.git > > For the whole patchset, after 'hacking' the bclk_ratio to correspond with > my imx6q ssi's wire format: > > Tested-by: Sven Van Asbroeck <TheSven73@gmail.com> Thanks.