| Message ID | 20190618074111.9309-1-marko.kohtala@okoko.fi (mailing list archive) |
|---|---|
| Headers | show |
| Series | video: ssd1307fb: Support more displays | expand |
On 6/18/19 9:41 AM, Marko Kohtala wrote: > The kernel driver for ssd1307fb did not allow for all proper > initialization for a Densitron 128x36 display. The trend in the driver > has been to add devicetree properties for the controller initialization > and these patches continue on that trend. > > There also were some sparse and Coccinelle errors. > > A small bug causing scrolling on display updates with nonzero page_offset > was a bit surprising. It would seem the driver has only been used with > page_offset set to zero. Bug has been there since commit > 301bc0675b677a98475187050d56cd2b39ff0acf ("video: ssd1307fb: Make use of > horizontal addressing mode"). > > Marko Kohtala (6): > video: ssd1307fb: Use screen_buffer instead of screen_base > video: ssd1307fb: Remove unneeded semicolons > video: ssd1307fb: Start page range at page_offset > video: ssd1307fb: Handle width and height that are not multiple of 8 > dt-bindings: display: ssd1307fb: Add initialization properties > video: ssd1307fb: Add devicetree configuration of display setup > > .../devicetree/bindings/display/ssd1307fb.txt | 10 ++ > drivers/video/fbdev/ssd1307fb.c | 130 ++++++++++++------ > 2 files changed, 101 insertions(+), 39 deletions(-) Patch series queued for v5.4, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
The kernel driver for ssd1307fb did not allow for all proper initialization for a Densitron 128x36 display. The trend in the driver has been to add devicetree properties for the controller initialization and these patches continue on that trend. There also were some sparse and Coccinelle errors. A small bug causing scrolling on display updates with nonzero page_offset was a bit surprising. It would seem the driver has only been used with page_offset set to zero. Bug has been there since commit 301bc0675b677a98475187050d56cd2b39ff0acf ("video: ssd1307fb: Make use of horizontal addressing mode"). Marko Kohtala (6): video: ssd1307fb: Use screen_buffer instead of screen_base video: ssd1307fb: Remove unneeded semicolons video: ssd1307fb: Start page range at page_offset video: ssd1307fb: Handle width and height that are not multiple of 8 dt-bindings: display: ssd1307fb: Add initialization properties video: ssd1307fb: Add devicetree configuration of display setup .../devicetree/bindings/display/ssd1307fb.txt | 10 ++ drivers/video/fbdev/ssd1307fb.c | 130 ++++++++++++------ 2 files changed, 101 insertions(+), 39 deletions(-)