mbox series

[0/6] drm/ttm: make ttm bo a gem bo subclass

Message ID 20190620074424.1677-1-kraxel@redhat.com (mailing list archive)
Headers show
Series drm/ttm: make ttm bo a gem bo subclass | expand

Message

Gerd Hoffmann June 20, 2019, 7:44 a.m. UTC
Gerd Hoffmann (6):
  drm/ttm: add gem base object
  drm/vram: use embedded gem object
  drm/qxl: use embedded gem object
  drm/ttm: use gem reservation object
  drm/ttm: use gem vma_node
  drm/vram: drop drm_gem_vram_driver_gem_prime_mmap

 drivers/gpu/drm/amd/amdgpu/amdgpu_object.h |  2 +-
 drivers/gpu/drm/qxl/qxl_drv.h              |  6 +--
 drivers/gpu/drm/qxl/qxl_object.h           |  6 +--
 drivers/gpu/drm/radeon/radeon_object.h     |  2 +-
 drivers/gpu/drm/virtio/virtgpu_drv.h       |  2 +-
 include/drm/drm_gem_vram_helper.h          |  7 +---
 include/drm/ttm/ttm_bo_api.h               | 24 ++++++++---
 drivers/gpu/drm/drm_gem_vram_helper.c      | 36 ++++------------
 drivers/gpu/drm/qxl/qxl_cmd.c              |  4 +-
 drivers/gpu/drm/qxl/qxl_debugfs.c          |  2 +-
 drivers/gpu/drm/qxl/qxl_display.c          |  8 ++--
 drivers/gpu/drm/qxl/qxl_gem.c              |  2 +-
 drivers/gpu/drm/qxl/qxl_object.c           | 20 ++++-----
 drivers/gpu/drm/qxl/qxl_release.c          |  2 +-
 drivers/gpu/drm/qxl/qxl_ttm.c              |  4 +-
 drivers/gpu/drm/ttm/ttm_bo.c               | 48 +++++++++++++---------
 drivers/gpu/drm/ttm/ttm_bo_util.c          |  4 +-
 drivers/gpu/drm/ttm/ttm_bo_vm.c            |  9 ++--
 drivers/gpu/drm/virtio/virtgpu_prime.c     |  3 --
 19 files changed, 94 insertions(+), 97 deletions(-)

Comments

Christian König June 21, 2019, 6:54 a.m. UTC | #1
Looks good on first glance.

But please also fix up all other drivers which use TTM andGEM with at 
least a trivial search, replace and compile test. If we are going to 
merge those or not directly is a different story.

Additional to that you can probably get rid of bo->resv as well after 
patch #4.

Regards,
Christian.

Am 20.06.19 um 09:44 schrieb Gerd Hoffmann:
>
> Gerd Hoffmann (6):
>    drm/ttm: add gem base object
>    drm/vram: use embedded gem object
>    drm/qxl: use embedded gem object
>    drm/ttm: use gem reservation object
>    drm/ttm: use gem vma_node
>    drm/vram: drop drm_gem_vram_driver_gem_prime_mmap
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.h |  2 +-
>   drivers/gpu/drm/qxl/qxl_drv.h              |  6 +--
>   drivers/gpu/drm/qxl/qxl_object.h           |  6 +--
>   drivers/gpu/drm/radeon/radeon_object.h     |  2 +-
>   drivers/gpu/drm/virtio/virtgpu_drv.h       |  2 +-
>   include/drm/drm_gem_vram_helper.h          |  7 +---
>   include/drm/ttm/ttm_bo_api.h               | 24 ++++++++---
>   drivers/gpu/drm/drm_gem_vram_helper.c      | 36 ++++------------
>   drivers/gpu/drm/qxl/qxl_cmd.c              |  4 +-
>   drivers/gpu/drm/qxl/qxl_debugfs.c          |  2 +-
>   drivers/gpu/drm/qxl/qxl_display.c          |  8 ++--
>   drivers/gpu/drm/qxl/qxl_gem.c              |  2 +-
>   drivers/gpu/drm/qxl/qxl_object.c           | 20 ++++-----
>   drivers/gpu/drm/qxl/qxl_release.c          |  2 +-
>   drivers/gpu/drm/qxl/qxl_ttm.c              |  4 +-
>   drivers/gpu/drm/ttm/ttm_bo.c               | 48 +++++++++++++---------
>   drivers/gpu/drm/ttm/ttm_bo_util.c          |  4 +-
>   drivers/gpu/drm/ttm/ttm_bo_vm.c            |  9 ++--
>   drivers/gpu/drm/virtio/virtgpu_prime.c     |  3 --
>   19 files changed, 94 insertions(+), 97 deletions(-)
>