mbox series

[0/5] drm: Aspect ratio fixes

Message ID 20190620142639.17518-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm: Aspect ratio fixes | expand

Message

Ville Syrjälä June 20, 2019, 2:26 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Ilia pointed out some oddball crap in the i915 aspect ratio handling.
While looking at that I noticed a bunch of fail in the core as well.
This series aims to fix it all.

Cc: Ilia Mirkin <imirkin@alum.mit.edu>

Ville Syrjälä (5):
  drm: Do not use bitwise OR to set picure_aspect_ratio
  drm: Do not accept garbage mode aspect ratio flags
  drm: WARN on illegal aspect ratio when converting a mode to umode
  drm/i915: Do not override mode's aspect ratio with the prop value NONE
  drm/i915: Drop redundant aspec ratio prop value initialization

 drivers/gpu/drm/drm_modes.c               | 17 +++++++++++------
 drivers/gpu/drm/i915/display/intel_hdmi.c |  5 ++---
 drivers/gpu/drm/i915/display/intel_sdvo.c |  4 +---
 3 files changed, 14 insertions(+), 12 deletions(-)

Comments

Alex Deucher June 21, 2019, 11:28 p.m. UTC | #1
On Thu, Jun 20, 2019 at 10:26 AM Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Ilia pointed out some oddball crap in the i915 aspect ratio handling.
> While looking at that I noticed a bunch of fail in the core as well.
> This series aims to fix it all.
>
> Cc: Ilia Mirkin <imirkin@alum.mit.edu>
>
> Ville Syrjälä (5):
>   drm: Do not use bitwise OR to set picure_aspect_ratio
>   drm: Do not accept garbage mode aspect ratio flags
>   drm: WARN on illegal aspect ratio when converting a mode to umode

Patches 1-3:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

>   drm/i915: Do not override mode's aspect ratio with the prop value NONE
>   drm/i915: Drop redundant aspec ratio prop value initialization
>
>  drivers/gpu/drm/drm_modes.c               | 17 +++++++++++------
>  drivers/gpu/drm/i915/display/intel_hdmi.c |  5 ++---
>  drivers/gpu/drm/i915/display/intel_sdvo.c |  4 +---
>  3 files changed, 14 insertions(+), 12 deletions(-)
>
> --
> 2.21.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Ville Syrjälä June 24, 2019, 3:12 p.m. UTC | #2
On Fri, Jun 21, 2019 at 07:28:30PM -0400, Alex Deucher wrote:
> On Thu, Jun 20, 2019 at 10:26 AM Ville Syrjala
> <ville.syrjala@linux.intel.com> wrote:
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Ilia pointed out some oddball crap in the i915 aspect ratio handling.
> > While looking at that I noticed a bunch of fail in the core as well.
> > This series aims to fix it all.
> >
> > Cc: Ilia Mirkin <imirkin@alum.mit.edu>
> >
> > Ville Syrjälä (5):
> >   drm: Do not use bitwise OR to set picure_aspect_ratio
> >   drm: Do not accept garbage mode aspect ratio flags
> >   drm: WARN on illegal aspect ratio when converting a mode to umode
> 
> Patches 1-3:
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Thanks. 1-3 pushed to drm-misc-next.