[0/3] drm/sun4i: Add support for color encoding and range

Message

Jernej Škrabec July 13, 2019, 12:03 p.m. UTC

In order to correctly convert image between YUV and RGB, you have to
know color encoding and color range. This patch set adds appropriate
properties and considers them when choosing CSC conversion matrix for
DE2 and DE3.

Note that this is only the half of needed changes when using HDMI output.
DW HDMI bridge driver has to be extended to have a property to select
limited (TVs) or full (PC monitors) range. But that will be done at a
later time.

Please take a look.

Best regards,
Jernej

Jernej Skrabec (3):
  drm/sun4i: Introduce color encoding and range properties
  drm/sun4i: sun8i_csc: Simplify register writes
  drm/sun4i: sun8i-csc: Add support for color encoding and range

 drivers/gpu/drm/sun4i/sun8i_csc.c      | 155 +++++++++++++++++++------
 drivers/gpu/drm/sun4i/sun8i_csc.h      |   6 +-
 drivers/gpu/drm/sun4i/sun8i_vi_layer.c |  21 +++-
 3 files changed, 146 insertions(+), 36 deletions(-)

Comments

Maxime Ripard July 20, 2019, 5:42 a.m. UTC | #1

On Sat, Jul 13, 2019 at 02:03:43PM +0200, Jernej Skrabec wrote:
> In order to correctly convert image between YUV and RGB, you have to
> know color encoding and color range. This patch set adds appropriate
> properties and considers them when choosing CSC conversion matrix for
> DE2 and DE3.
>
> Note that this is only the half of needed changes when using HDMI output.
> DW HDMI bridge driver has to be extended to have a property to select
> limited (TVs) or full (PC monitors) range. But that will be done at a
> later time.
>
> Please take a look.

Sorry for the delay, I applied all three.

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Jernej Škrabec July 20, 2019, 4:03 p.m. UTC | #2

Dne sobota, 20. julij 2019 ob 07:42:55 CEST je Maxime Ripard napisal(a):
> On Sat, Jul 13, 2019 at 02:03:43PM +0200, Jernej Skrabec wrote:
> > In order to correctly convert image between YUV and RGB, you have to
> > know color encoding and color range. This patch set adds appropriate
> > properties and considers them when choosing CSC conversion matrix for
> > DE2 and DE3.
> > 
> > Note that this is only the half of needed changes when using HDMI output.
> > DW HDMI bridge driver has to be extended to have a property to select
> > limited (TVs) or full (PC monitors) range. But that will be done at a
> > later time.
> > 
> > Please take a look.
> 
> Sorry for the delay, I applied all three.

No problem. Thanks!

Best regards,
Jernej